Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-28 Thread Arnd Bergmann
On Wednesday 27 January 2016 17:04:47 Nicolas Ferre wrote: > > > > Okay Arnd, thanks! > > > > Acked-by: Nicolas Ferre > > Oh, crap: actually this warning has just been fixed by Sudip Mukherjee > and is already queued by David here: > https://patchwork.ozlabs.org/patch/572610/ > > So, sorry,

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-28 Thread Sergei Shtylyov
Hello. On 1/27/2016 5:04 PM, Arnd Bergmann wrote: The macb_clk_init function returns three clock pointers, unless the it fails to get the first ones. We correctly handle the s/the//. failure case by propagating the error from macb_probe, but gcc does not realize this and incorrectly

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-28 Thread Arnd Bergmann
On Wednesday 27 January 2016 17:04:47 Nicolas Ferre wrote: > > > > Okay Arnd, thanks! > > > > Acked-by: Nicolas Ferre > > Oh, crap: actually this warning has just been fixed by Sudip Mukherjee > and is already queued by David here: >

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-28 Thread Sergei Shtylyov
Hello. On 1/27/2016 5:04 PM, Arnd Bergmann wrote: The macb_clk_init function returns three clock pointers, unless the it fails to get the first ones. We correctly handle the s/the//. failure case by propagating the error from macb_probe, but gcc does not realize this and incorrectly

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 16:51, Nicolas Ferre a écrit : > Le 27/01/2016 15:04, Arnd Bergmann a écrit : >> The macb_clk_init function returns three clock pointers, unless >> the it fails to get the first ones. We correctly handle the >> failure case by propagating the error from macb_probe, but >> gcc does

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 15:04, Arnd Bergmann a écrit : > The macb_clk_init function returns three clock pointers, unless > the it fails to get the first ones. We correctly handle the > failure case by propagating the error from macb_probe, but > gcc does not realize this and incorrectly warns about a later

[PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Arnd Bergmann
The macb_clk_init function returns three clock pointers, unless the it fails to get the first ones. We correctly handle the failure case by propagating the error from macb_probe, but gcc does not realize this and incorrectly warns about a later use of those: In file included from

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 15:04, Arnd Bergmann a écrit : > The macb_clk_init function returns three clock pointers, unless > the it fails to get the first ones. We correctly handle the > failure case by propagating the error from macb_probe, but > gcc does not realize this and incorrectly warns about a later

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 16:51, Nicolas Ferre a écrit : > Le 27/01/2016 15:04, Arnd Bergmann a écrit : >> The macb_clk_init function returns three clock pointers, unless >> the it fails to get the first ones. We correctly handle the >> failure case by propagating the error from macb_probe, but >> gcc does

[PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Arnd Bergmann
The macb_clk_init function returns three clock pointers, unless the it fails to get the first ones. We correctly handle the failure case by propagating the error from macb_probe, but gcc does not realize this and incorrectly warns about a later use of those: In file included from