Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 03:21:46PM +0200, Jiri Olsa escreveu: > On Wed, Oct 14, 2020 at 08:59:08AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > > > We do not store size with build ids in perf data, > > > but there's enough space to do

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > We do not store size with build ids in perf data, > but there's enough space to do it. Adding misc bit > PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id event > with size. > > With this fix the dso with md5 build id will have correct

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Jiri Olsa
On Wed, Oct 14, 2020 at 08:59:08AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > > We do not store size with build ids in perf data, > > but there's enough space to do it. Adding misc bit > > PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > We do not store size with build ids in perf data, > but there's enough space to do it. Adding misc bit > PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id event > with size. > > With this fix the dso with md5 build id will have correct

[PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-13 Thread Jiri Olsa
We do not store size with build ids in perf data, but there's enough space to do it. Adding misc bit PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id event with size. With this fix the dso with md5 build id will have correct build id data and will be usable for debuginfod processing if needed