1. In order to remove duplicate code, following functions:
platform_get_resource
devm_kzalloc
devm_ioremap_resource
devm_clk_get
platform_get_irq
are replaced with a macro devm_platform_probe_helper.

2. This patch depends on the file include/linux/probe-helper.h
which is pushed in previous patch [01/09].

Signed-off-by: Satendra Singh Thakur <satendrasingh.tha...@hcl.com>
Signed-off-by: Satendra Singh Thakur <sst2...@gmail.com>
---
 drivers/dma/sun4i-dma.c | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 1f80568b2613..5db139ff43ac 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -15,6 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
+#include <linux/probe-helper.h>
 
 #include "virt-dma.h"
 
@@ -1119,29 +1120,16 @@ static irqreturn_t sun4i_dma_interrupt(int irq, void 
*dev_id)
 static int sun4i_dma_probe(struct platform_device *pdev)
 {
        struct sun4i_dma_dev *priv;
-       struct resource *res;
        int i, j, ret;
 
-       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
-       if (!priv)
-               return -ENOMEM;
-
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       priv->base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(priv->base))
-               return PTR_ERR(priv->base);
-
-       priv->irq = platform_get_irq(pdev, 0);
-       if (priv->irq < 0) {
-               dev_err(&pdev->dev, "Cannot claim IRQ\n");
-               return priv->irq;
-       }
-
-       priv->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(priv->clk)) {
-               dev_err(&pdev->dev, "No clock specified\n");
-               return PTR_ERR(priv->clk);
-       }
+       /*
+        * This macro internally combines following functions:
+        * devm_kzalloc, platform_get_resource, devm_ioremap_resource,
+        * devm_clk_get, platform_get_irq
+        */
+       ret = devm_platform_probe_helper(pdev, priv, NULL);
+       if (ret < 0)
+               return ret;
 
        platform_set_drvdata(pdev, priv);
        spin_lock_init(&priv->lock);
-- 
2.17.1

Reply via email to