Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-23 Thread Wen Congyang
At 10/23/2012 03:09 PM, wujianguo Wrote: > On 2012-10-22 15:11, Wen Congyang wrote: >> Hi, Wu >> >> Sorry for late reply. >> >> At 10/09/2012 04:26 PM, wujianguo Wrote: >>> Hi Congyang, >>> I think we should also free pages which are used by page tables after >>> removing >>> page tables of

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-23 Thread wujianguo
On 2012-10-22 15:11, Wen Congyang wrote: > Hi, Wu > > Sorry for late reply. > > At 10/09/2012 04:26 PM, wujianguo Wrote: >> Hi Congyang, >> I think we should also free pages which are used by page tables after >> removing >> page tables of the memory. > > It is OK to do it. > >> >> From:

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-23 Thread wujianguo
On 2012-10-22 15:11, Wen Congyang wrote: Hi, Wu Sorry for late reply. At 10/09/2012 04:26 PM, wujianguo Wrote: Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. It is OK to do it. From: Jianguo Wu

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-23 Thread Wen Congyang
At 10/23/2012 03:09 PM, wujianguo Wrote: On 2012-10-22 15:11, Wen Congyang wrote: Hi, Wu Sorry for late reply. At 10/09/2012 04:26 PM, wujianguo Wrote: Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. It is OK

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-22 Thread Wen Congyang
Hi, Wu Sorry for late reply. At 10/09/2012 04:26 PM, wujianguo Wrote: > Hi Congyang, > I think we should also free pages which are used by page tables after > removing > page tables of the memory. It is OK to do it. > > From: Jianguo Wu > > Signed-off-by: Jianguo Wu > Signed-off-by:

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-22 Thread Wen Congyang
Hi, Wu Sorry for late reply. At 10/09/2012 04:26 PM, wujianguo Wrote: Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. It is OK to do it. From: Jianguo Wu wujian...@huawei.com Signed-off-by: Jianguo Wu

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-10 Thread Ni zhan Chen
On 10/08/2012 01:23 PM, Wen Congyang wrote: At 10/08/2012 12:37 PM, Andi Kleen Wrote: Yasuaki Ishimatsu writes: + } + + /* +* We use 2M page, but we need to remove part of them, +* so split 2M page to

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-10 Thread Ni zhan Chen
On 10/08/2012 01:23 PM, Wen Congyang wrote: At 10/08/2012 12:37 PM, Andi Kleen Wrote: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com writes: + } + + /* +* We use 2M page, but we need to remove part of them, +

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-09 Thread wujianguo
Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. From: Jianguo Wu Signed-off-by: Jianguo Wu Signed-off-by: Jiang Liu --- arch/x86/mm/init_64.c | 110 +++- 1 files

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-09 Thread wujianguo
Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. From: Jianguo Wu wujian...@huawei.com Signed-off-by: Jianguo Wu wujian...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- arch/x86/mm/init_64.c | 110

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-07 Thread Wen Congyang
At 10/08/2012 12:37 PM, Andi Kleen Wrote: > Yasuaki Ishimatsu writes: >> +} >> + >> +/* >> + * We use 2M page, but we need to remove part of them, >> + * so split 2M page to 4K page. >> + */ >> +

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-07 Thread Andi Kleen
Yasuaki Ishimatsu writes: > + } > + > + /* > + * We use 2M page, but we need to remove part of them, > + * so split 2M page to 4K page. > + */ > + pte =

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-07 Thread Andi Kleen
Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com writes: + } + + /* + * We use 2M page, but we need to remove part of them, + * so split 2M page to 4K page. + */ + pte

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-07 Thread Wen Congyang
At 10/08/2012 12:37 PM, Andi Kleen Wrote: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com writes: +} + +/* + * We use 2M page, but we need to remove part of them, + * so split 2M page to 4K page. +

[PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-04 Thread Yasuaki Ishimatsu
From: Wen Congyang For hot removing memory, we sholud remove page table about the memory. So the patch searches a page table about the removed memory, and clear page table. CC: David Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter Cc: Minchan Kim CC: Andrew Morton CC: KOSAKI

[PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-04 Thread Yasuaki Ishimatsu
From: Wen Congyang we...@cn.fujitsu.com For hot removing memory, we sholud remove page table about the memory. So the patch searches a page table about the removed memory, and clear page table. CC: David Rientjes rient...@google.com CC: Jiang Liu liu...@gmail.com CC: Len Brown