R: Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-15 Thread Paolo Bonzini
- Eric Wheeler ha scritto: > On Sat, 13 Jan 2018, Paolo Bonzini wrote: > > > Just add the new MSR at the end of the array. > > I'm assuming you meant emulated_msrs[], correct? No, msrs_to_save. It's just above emulated_msrs. Paolo > > > -- > Eric Wheeler > >

R: Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-15 Thread Paolo Bonzini
- Eric Wheeler ha scritto: > On Sat, 13 Jan 2018, Paolo Bonzini wrote: > > > Just add the new MSR at the end of the array. > > I'm assuming you meant emulated_msrs[], correct? No, msrs_to_save. It's just above emulated_msrs. Paolo > > > -- > Eric Wheeler > > > > > > > Paolo > >

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-15 Thread Eric Wheeler
On Sat, 13 Jan 2018, Paolo Bonzini wrote: > Just add the new MSR at the end of the array. I'm assuming you meant emulated_msrs[], correct? -- Eric Wheeler > > Paolo > > - Eric Wheeler ha scritto: > > On Tue, 9 Jan 2018, Paolo Bonzini wrote: > > > > >

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-15 Thread Eric Wheeler
On Sat, 13 Jan 2018, Paolo Bonzini wrote: > Just add the new MSR at the end of the array. I'm assuming you meant emulated_msrs[], correct? -- Eric Wheeler > > Paolo > > - Eric Wheeler ha scritto: > > On Tue, 9 Jan 2018, Paolo Bonzini wrote: > > > > > Expose them to userspace, now

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-13 Thread Paolo Bonzini
Just add the new MSR at the end of the array. Paolo - Eric Wheeler ha scritto: > On Tue, 9 Jan 2018, Paolo Bonzini wrote: > > > Expose them to userspace, now that guests can use them. > > I am not adding cpufeatures here to avoid having a kernel > > that shows

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-13 Thread Paolo Bonzini
Just add the new MSR at the end of the array. Paolo - Eric Wheeler ha scritto: > On Tue, 9 Jan 2018, Paolo Bonzini wrote: > > > Expose them to userspace, now that guests can use them. > > I am not adding cpufeatures here to avoid having a kernel > > that shows spec_ctrl in /proc/cpuinfo

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-12 Thread Eric Wheeler
On Tue, 9 Jan 2018, Paolo Bonzini wrote: > Expose them to userspace, now that guests can use them. > I am not adding cpufeatures here to avoid having a kernel > that shows spec_ctrl in /proc/cpuinfo and actually has no > support whatsoever for IBRS/IBPB. Keep the ugly special-casing > for now,

Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-12 Thread Eric Wheeler
On Tue, 9 Jan 2018, Paolo Bonzini wrote: > Expose them to userspace, now that guests can use them. > I am not adding cpufeatures here to avoid having a kernel > that shows spec_ctrl in /proc/cpuinfo and actually has no > support whatsoever for IBRS/IBPB. Keep the ugly special-casing > for now,

[PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-09 Thread Paolo Bonzini
Expose them to userspace, now that guests can use them. I am not adding cpufeatures here to avoid having a kernel that shows spec_ctrl in /proc/cpuinfo and actually has no support whatsoever for IBRS/IBPB. Keep the ugly special-casing for now, and clean it up once the generic arch/x86/ code

[PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-09 Thread Paolo Bonzini
Expose them to userspace, now that guests can use them. I am not adding cpufeatures here to avoid having a kernel that shows spec_ctrl in /proc/cpuinfo and actually has no support whatsoever for IBRS/IBPB. Keep the ugly special-casing for now, and clean it up once the generic arch/x86/ code