Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-29 Thread Darren Hart
On Tue, Oct 28, 2014 at 09:09:03AM +0100, Frans Klaver wrote: > On Tue, Oct 28, 2014 at 6:34 AM, Darren Hart wrote: > > On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: > >> In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a > >> bool. However, it is possible

Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-29 Thread Darren Hart
On Tue, Oct 28, 2014 at 09:09:03AM +0100, Frans Klaver wrote: On Tue, Oct 28, 2014 at 6:34 AM, Darren Hart dvh...@infradead.org wrote: On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is

Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-28 Thread Frans Klaver
On Tue, Oct 28, 2014 at 6:34 AM, Darren Hart wrote: > On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: >> In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a >> bool. However, it is possible that get_acpi() returns an error instead. >> We should not be writing

Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-28 Thread Frans Klaver
On Tue, Oct 28, 2014 at 6:34 AM, Darren Hart dvh...@infradead.org wrote: On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is possible that get_acpi() returns an error instead. We should not

Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-27 Thread Darren Hart
On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: > In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a > bool. However, it is possible that get_acpi() returns an error instead. > We should not be writing error values to the ACPI device, even though > it's quite

Re: [PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-27 Thread Darren Hart
On Wed, Oct 22, 2014 at 09:12:43PM +0200, Frans Klaver wrote: In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is possible that get_acpi() returns an error instead. We should not be writing error values to the ACPI device, even though it's quite

[PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-22 Thread Frans Klaver
In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is possible that get_acpi() returns an error instead. We should not be writing error values to the ACPI device, even though it's quite possible that we couldn't contact the ACPI device in the first place.

[PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-22 Thread Frans Klaver
In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is possible that get_acpi() returns an error instead. We should not be writing error values to the ACPI device, even though it's quite possible that we couldn't contact the ACPI device in the first place.