On 06/17/2014 11:36 AM, Mikko Perttunen wrote:
> On 06/17/2014 08:04 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> Hi,
>>
>> On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
>>> On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
>>
>> [...]
>>
> +static struct platform_driver
On 06/17/2014 08:04 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
[...]
+static struct platform_driver tegra_ahci_driver = {
+ .probe = tegra_ahci_probe,
+ .remove =
Hi,
On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
> On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
[...]
> >> +static struct platform_driver tegra_ahci_driver = {
> >> + .probe = tegra_ahci_probe,
> >> + .remove = ata_platform_remove_one,
> >> + .driver = {
> >> +
On 06/17/2014 10:14 AM, Tejun Heo wrote:
> On Tue, Jun 17, 2014 at 12:13:20PM -0400, Tejun Heo wrote:
>> On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
sata_writel() and sata_read() static inlines don't seem to add any value.
Can they be removed?
>>>
>>> Such
On Tue, Jun 17, 2014 at 10:23:01AM -0600, Stephen Warren wrote:
> > Please also drop inline. It isn't a difficult optimization to perform
> > for the compiler.
>
> There are probably hundreds of drivers marking those functions inline.
We used to need them. We no longer do. We're in a very
On Tue, Jun 17, 2014 at 12:13:20PM -0400, Tejun Heo wrote:
> On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
> > > sata_writel() and sata_read() static inlines don't seem to add any value.
> > >
> > > Can they be removed?
> >
> > Such functions are quite idiomatic in drivers, and
On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
> > sata_writel() and sata_read() static inlines don't seem to add any value.
> >
> > Can they be removed?
>
> Such functions are quite idiomatic in drivers, and serve to simplify all
> the call-sites by removing the need to write
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, June 04, 2014 02:32:38 PM Mikko Perttunen wrote:
>> This adds support for the integrated AHCI-compliant Serial ATA
>> controller present on the NVIDIA Tegra124 system-on-chip.
>> +static inline void
Hi,
On Wednesday, June 04, 2014 02:32:38 PM Mikko Perttunen wrote:
> This adds support for the integrated AHCI-compliant Serial ATA
> controller present on the NVIDIA Tegra124 system-on-chip.
>
> Signed-off-by: Mikko Perttunen
> ---
> drivers/ata/Kconfig | 9 ++
> drivers/ata/Makefile
Hi,
On Wednesday, June 04, 2014 02:32:38 PM Mikko Perttunen wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com
---
drivers/ata/Kconfig | 9 ++
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Wednesday, June 04, 2014 02:32:38 PM Mikko Perttunen wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
+static inline void sata_writel(struct
On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
sata_writel() and sata_read() static inlines don't seem to add any value.
Can they be removed?
Such functions are quite idiomatic in drivers, and serve to simplify all
the call-sites by removing the need to write out the
On Tue, Jun 17, 2014 at 12:13:20PM -0400, Tejun Heo wrote:
On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
sata_writel() and sata_read() static inlines don't seem to add any value.
Can they be removed?
Such functions are quite idiomatic in drivers, and serve to
On Tue, Jun 17, 2014 at 10:23:01AM -0600, Stephen Warren wrote:
Please also drop inline. It isn't a difficult optimization to perform
for the compiler.
There are probably hundreds of drivers marking those functions inline.
We used to need them. We no longer do. We're in a very long
On 06/17/2014 10:14 AM, Tejun Heo wrote:
On Tue, Jun 17, 2014 at 12:13:20PM -0400, Tejun Heo wrote:
On Tue, Jun 17, 2014 at 10:10:23AM -0600, Stephen Warren wrote:
sata_writel() and sata_read() static inlines don't seem to add any value.
Can they be removed?
Such functions are quite
Hi,
On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
[...]
+static struct platform_driver tegra_ahci_driver = {
+ .probe = tegra_ahci_probe,
+ .remove = ata_platform_remove_one,
+ .driver = {
+ .name =
On 06/17/2014 08:04 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
[...]
+static struct platform_driver tegra_ahci_driver = {
+ .probe = tegra_ahci_probe,
+ .remove =
On 06/17/2014 11:36 AM, Mikko Perttunen wrote:
On 06/17/2014 08:04 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Tuesday, June 17, 2014 10:10:23 AM Stephen Warren wrote:
On 06/17/2014 06:14 AM, Bartlomiej Zolnierkiewicz wrote:
[...]
+static struct platform_driver tegra_ahci_driver = {
+
On 06/04/2014 05:32 AM, Mikko Perttunen wrote:
> This adds support for the integrated AHCI-compliant Serial ATA
> controller present on the NVIDIA Tegra124 system-on-chip.
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> +static int tegra_ahci_controller_init(struct
On 06/04/2014 05:32 AM, Mikko Perttunen wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
+static int tegra_ahci_controller_init(struct
Thanks, will remove.
- Mikko
On 05/06/14 15:18, Rob Herring wrote:
On Wed, Jun 4, 2014 at 6:32 AM, Mikko Perttunen wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko Perttunen
---
[...]
On Wed, Jun 4, 2014 at 6:32 AM, Mikko Perttunen wrote:
> This adds support for the integrated AHCI-compliant Serial ATA
> controller present on the NVIDIA Tegra124 system-on-chip.
>
> Signed-off-by: Mikko Perttunen
> ---
[...]
> +static int tegra_ahci_probe(struct platform_device *pdev)
> +{
>
On Wed, Jun 4, 2014 at 6:32 AM, Mikko Perttunen mperttu...@nvidia.com wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com
---
[...]
+static int
Thanks, will remove.
- Mikko
On 05/06/14 15:18, Rob Herring wrote:
On Wed, Jun 4, 2014 at 6:32 AM, Mikko Perttunen mperttu...@nvidia.com wrote:
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko Perttunen
---
drivers/ata/Kconfig | 9 ++
drivers/ata/Makefile | 1 +
drivers/ata/ahci_tegra.c | 386
This adds support for the integrated AHCI-compliant Serial ATA
controller present on the NVIDIA Tegra124 system-on-chip.
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com
---
drivers/ata/Kconfig | 9 ++
drivers/ata/Makefile | 1 +
drivers/ata/ahci_tegra.c | 386
26 matches
Mail list logo
