RE: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-04 Thread Kyungmin Park
To make a modules, we have to export "get_mtd_blktrans_gendisk". "get_mtd_blktrans_gendisk" is used at mtdswap. > > +struct gendisk *get_mtd_blktrans_gendisk(struct > mtd_blktrans_dev *dev) > +{ > + return dev->blkcore_priv; > +} > + @@ -469,6 +480,7 @@

Re: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-04 Thread Arnd Bergmann
On Friday 02 March 2007 16:55:02 Richard Purdie wrote: > Allow mtd block drivers to customise their ioctl functions. Also > allow the drivers to obtain the gendisk struct since ioctl > functions can need this. Are you sure that this is a good idea? I'd rather not open up this method of letting

Re: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-04 Thread Arnd Bergmann
On Friday 02 March 2007 16:55:02 Richard Purdie wrote: Allow mtd block drivers to customise their ioctl functions. Also allow the drivers to obtain the gendisk struct since ioctl functions can need this. Are you sure that this is a good idea? I'd rather not open up this method of letting the

RE: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-04 Thread Kyungmin Park
To make a modules, we have to export get_mtd_blktrans_gendisk. get_mtd_blktrans_gendisk is used at mtdswap. +struct gendisk *get_mtd_blktrans_gendisk(struct mtd_blktrans_dev *dev) +{ + return dev-blkcore_priv; +} + @@ -469,6 +480,7 @@ EXPORT_SYMBOL_GPL(register_mtd_blktrans);

[PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-02 Thread Richard Purdie
Allow mtd block drivers to customise their ioctl functions. Also allow the drivers to obtain the gendisk struct since ioctl functions can need this. This also moves the mtd ioctl functions from locked to unlocked. As far as I can see, nothing in the mtd code has locking problems. Signed-off-by:

[PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function

2007-03-02 Thread Richard Purdie
Allow mtd block drivers to customise their ioctl functions. Also allow the drivers to obtain the gendisk struct since ioctl functions can need this. This also moves the mtd ioctl functions from locked to unlocked. As far as I can see, nothing in the mtd code has locking problems. Signed-off-by: