[PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-21 Thread Namhyung Kim
From: Namhyung Kim Convert them to pr_debug() and propagate error code. Cc: Steven Rostedt Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/trace-event-read.c | 44 +- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git

[PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-21 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Convert them to pr_debug() and propagate error code. Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/util/trace-event-read.c | 44

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-20 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 20, 2013 at 10:25:52AM +0900, Namhyung Kim escreveu: > On Tue, 19 Mar 2013 10:55:28 -0400, Steven Rostedt wrote: > > On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: > >> Convert them to pr_debug() and propagate error code. > > Shouldn't they be pr_err(). I mean, if the old code

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Namhyung Kim
On Tue, 19 Mar 2013 10:55:28 -0400, Steven Rostedt wrote: > On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> Convert them to pr_debug() and propagate error code. > > Shouldn't they be pr_err(). I mean, if the old code would kill the > process, why just keep it

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Steven Rostedt
On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Convert them to pr_debug() and propagate error code. Shouldn't they be pr_err(). I mean, if the old code would kill the process, why just keep it as a debug output? -- Steve > > Cc: Steven Rostedt > Cc: Frederic

[PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Namhyung Kim
From: Namhyung Kim Convert them to pr_debug() and propagate error code. Cc: Steven Rostedt Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/trace-event-read.c | 44 +- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git

[PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Convert them to pr_debug() and propagate error code. Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/util/trace-event-read.c | 44

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Steven Rostedt
On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com Convert them to pr_debug() and propagate error code. Shouldn't they be pr_err(). I mean, if the old code would kill the process, why just keep it as a debug output? -- Steve Cc: Steven Rostedt

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-19 Thread Namhyung Kim
On Tue, 19 Mar 2013 10:55:28 -0400, Steven Rostedt wrote: On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com Convert them to pr_debug() and propagate error code. Shouldn't they be pr_err(). I mean, if the old code would kill the process, why just