Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-08 Thread Shivani Bhardwaj
On Sun, Nov 8, 2015 at 2:17 AM, Dan Carpenter wrote: > Don't resend, it's fine. I don't like re-reviewing patches and you > don't like sending them. It's not like it introduces a bug or generate > a warning with our current tools. > > But it's still important to understand how the one thing per

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-08 Thread Shivani Bhardwaj
On Sun, Nov 8, 2015 at 2:17 AM, Dan Carpenter wrote: > Don't resend, it's fine. I don't like re-reviewing patches and you > don't like sending them. It's not like it introduces a bug or generate > a warning with our current tools. > > But it's still important to

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Dan Carpenter
Don't resend, it's fine. I don't like re-reviewing patches and you don't like sending them. It's not like it introduces a bug or generate a warning with our current tools. But it's still important to understand how the one thing per patch rule works (don't do half a thing per patch) so I wanted

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Shivani Bhardwaj
On Sat, Nov 7, 2015 at 4:15 PM, Dan Carpenter wrote: > This one should have been folded in with the last one. Really the whole > series could have been sent as one patch, but especially the last two > should have been folded together. > > regards, > dan carpenter > Thanks Dan! Could you please

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Dan Carpenter
This one should have been folded in with the last one. Really the whole series could have been sent as one patch, but especially the last two should have been folded together. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Shivani Bhardwaj
On Sat, Nov 7, 2015 at 4:15 PM, Dan Carpenter wrote: > This one should have been folded in with the last one. Really the whole > series could have been sent as one patch, but especially the last two > should have been folded together. > > regards, > dan carpenter >

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Dan Carpenter
This one should have been folded in with the last one. Really the whole series could have been sent as one patch, but especially the last two should have been folded together. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-07 Thread Dan Carpenter
Don't resend, it's fine. I don't like re-reviewing patches and you don't like sending them. It's not like it introduces a bug or generate a warning with our current tools. But it's still important to understand how the one thing per patch rule works (don't do half a thing per patch) so I wanted

[PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-06 Thread Shivani Bhardwaj
Remove the prototype of the function ll_finish_md_op_data() as it is no longer needed. Signed-off-by: Shivani Bhardwaj --- drivers/staging/lustre/lustre/llite/llite_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_internal.h

[PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype

2015-11-06 Thread Shivani Bhardwaj
Remove the prototype of the function ll_finish_md_op_data() as it is no longer needed. Signed-off-by: Shivani Bhardwaj --- drivers/staging/lustre/lustre/llite/llite_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git