Re: [PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-08 Thread Takashi Iwai
On Mon, 08 Oct 2018 11:34:25 +0200, Mark Brown wrote: > > On Fri, Oct 05, 2018 at 12:14:04PM -0400, Sasha Levin wrote: > > From: Yu Zhao > > > > [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] > > > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > > 1) sets

Re: [PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-08 Thread Takashi Iwai
On Mon, 08 Oct 2018 11:34:25 +0200, Mark Brown wrote: > > On Fri, Oct 05, 2018 at 12:14:04PM -0400, Sasha Levin wrote: > > From: Yu Zhao > > > > [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] > > > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > > 1) sets

Re: [PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-08 Thread Mark Brown
On Fri, Oct 05, 2018 at 12:14:04PM -0400, Sasha Levin wrote: > From: Yu Zhao > > [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > 1) sets bus->chip_init to prevent multiple entrances before device > is stopped;

Re: [PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-08 Thread Mark Brown
On Fri, Oct 05, 2018 at 12:14:04PM -0400, Sasha Levin wrote: > From: Yu Zhao > > [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > 1) sets bus->chip_init to prevent multiple entrances before device > is stopped;

[PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-05 Thread Sasha Levin
From: Yu Zhao [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which 1) sets bus->chip_init to prevent multiple entrances before device is stopped; 2) enables interrupt. We shouldn't use it for the purpose of resetting

[PATCH AUTOSEL 4.18 28/48] sound: don't call skl_init_chip() to reset intel skl soc

2018-10-05 Thread Sasha Levin
From: Yu Zhao [ Upstream commit 75383f8d39d4c0fb96083dd460b7b139fbdac492 ] Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which 1) sets bus->chip_init to prevent multiple entrances before device is stopped; 2) enables interrupt. We shouldn't use it for the purpose of resetting