Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Dave Chinner
On Thu, Nov 29, 2018 at 02:36:50PM +0200, Amir Goldstein wrote: > > Same again - what's the test plan for these cherry-picked data > > corruption fixes? > > > > Dave, > > Just to check if we are on the same page, if this was the test plan: > https://www.spinics.net/lists/linux-xfs/msg20639.html

Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Dave Chinner
On Thu, Nov 29, 2018 at 02:36:50PM +0200, Amir Goldstein wrote: > > Same again - what's the test plan for these cherry-picked data > > corruption fixes? > > > > Dave, > > Just to check if we are on the same page, if this was the test plan: > https://www.spinics.net/lists/linux-xfs/msg20639.html

Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Amir Goldstein
> Same again - what's the test plan for these cherry-picked data > corruption fixes? > Dave, Just to check if we are on the same page, if this was the test plan: https://www.spinics.net/lists/linux-xfs/msg20639.html Would "no regressions from baseline" have been sufficient to validate those

Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Amir Goldstein
> Same again - what's the test plan for these cherry-picked data > corruption fixes? > Dave, Just to check if we are on the same page, if this was the test plan: https://www.spinics.net/lists/linux-xfs/msg20639.html Would "no regressions from baseline" have been sufficient to validate those

Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Dave Chinner
On Thu, Nov 29, 2018 at 12:55:43AM -0500, Sasha Levin wrote: > From: Dave Chinner > > [ Upstream commit b450672fb66b4a991a5b55ee24209ac7ae7690ce ] > > If we are doing sub-block dio that extends EOF, we need to zero > the unused tail of the block to initialise the data in it it. If we > do not

Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Dave Chinner
On Thu, Nov 29, 2018 at 12:55:43AM -0500, Sasha Levin wrote: > From: Dave Chinner > > [ Upstream commit b450672fb66b4a991a5b55ee24209ac7ae7690ce ] > > If we are doing sub-block dio that extends EOF, we need to zero > the unused tail of the block to initialise the data in it it. If we > do not

[PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-28 Thread Sasha Levin
From: Dave Chinner [ Upstream commit b450672fb66b4a991a5b55ee24209ac7ae7690ce ] If we are doing sub-block dio that extends EOF, we need to zero the unused tail of the block to initialise the data in it it. If we do not zero the tail of the block, then an immediate mmap read of the EOF block

[PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-28 Thread Sasha Levin
From: Dave Chinner [ Upstream commit b450672fb66b4a991a5b55ee24209ac7ae7690ce ] If we are doing sub-block dio that extends EOF, we need to zero the unused tail of the block to initialise the data in it it. If we do not zero the tail of the block, then an immediate mmap read of the EOF block