Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:32:15AM +0200, Pavel Machek wrote: >Hi! > >> >- It must be obviously correct and tested. >> > >> >If it introduces new bug, it is not correct, and certainly not >> >obviously correct. >> >> As you might have noticed, we don't strictly follow the rules. > >Yes, I noticed.

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:32:15AM +0200, Pavel Machek wrote: >Hi! > >> >- It must be obviously correct and tested. >> > >> >If it introduces new bug, it is not correct, and certainly not >> >obviously correct. >> >> As you might have noticed, we don't strictly follow the rules. > >Yes, I noticed.

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:36:51AM +0200, Pavel Machek wrote: >On Tue 2018-04-17 16:19:35, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: >> >On Tue 17-04-18 13:31:51, Sasha Levin wrote: >> >> We may be able to guesstimate the 'regression chance', but there's no >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:36:51AM +0200, Pavel Machek wrote: >On Tue 2018-04-17 16:19:35, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: >> >On Tue 17-04-18 13:31:51, Sasha Levin wrote: >> >> We may be able to guesstimate the 'regression chance', but there's no >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:47:24AM +0200, Pavel Machek wrote: >On Mon 2018-04-16 21:18:47, Sasha Levin wrote: >> On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: >> >On Mon, 16 Apr 2018, Sasha Levin wrote: >> > >> >> So I think that Linus's claim that users come first applies here as

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 11:47:24AM +0200, Pavel Machek wrote: >On Mon 2018-04-16 21:18:47, Sasha Levin wrote: >> On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: >> >On Mon, 16 Apr 2018, Sasha Levin wrote: >> > >> >> So I think that Linus's claim that users come first applies here as

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 12:04:41PM +0200, Pavel Machek wrote: >On Tue 2018-04-17 16:06:29, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: >> >On Tue, 17 Apr 2018, Sasha Levin wrote: >> > >> >> How do I get the XFS folks to send their stuff to -stable? (we have

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, May 03, 2018 at 12:04:41PM +0200, Pavel Machek wrote: >On Tue 2018-04-17 16:06:29, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: >> >On Tue, 17 Apr 2018, Sasha Levin wrote: >> > >> >> How do I get the XFS folks to send their stuff to -stable? (we have

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 16:06:29, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: > >On Tue, 17 Apr 2018, Sasha Levin wrote: > > > >> How do I get the XFS folks to send their stuff to -stable? (we have > >> quite a few customers who use XFS) > > > >If XFS (or *any*

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 16:06:29, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: > >On Tue, 17 Apr 2018, Sasha Levin wrote: > > > >> How do I get the XFS folks to send their stuff to -stable? (we have > >> quite a few customers who use XFS) > > > >If XFS (or *any*

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon 2018-04-16 21:18:47, Sasha Levin wrote: > On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: > >On Mon, 16 Apr 2018, Sasha Levin wrote: > > > >> So I think that Linus's claim that users come first applies here as > >> well. If there's a user that cares about a particular feature

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon 2018-04-16 21:18:47, Sasha Levin wrote: > On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: > >On Mon, 16 Apr 2018, Sasha Levin wrote: > > > >> So I think that Linus's claim that users come first applies here as > >> well. If there's a user that cares about a particular feature

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 16:19:35, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: > >On Tue 17-04-18 13:31:51, Sasha Levin wrote: > >> We may be able to guesstimate the 'regression chance', but there's no > >> way we can guess the 'annoyance' once. There are so many

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 16:19:35, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: > >On Tue 17-04-18 13:31:51, Sasha Levin wrote: > >> We may be able to guesstimate the 'regression chance', but there's no > >> way we can guess the 'annoyance' once. There are so many

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Hi! > >- It must be obviously correct and tested. > > > >If it introduces new bug, it is not correct, and certainly not > >obviously correct. > > As you might have noticed, we don't strictly follow the rules. Yes, I noticed. And what I'm saying is that perhaps you should follow the rules more

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Hi! > >- It must be obviously correct and tested. > > > >If it introduces new bug, it is not correct, and certainly not > >obviously correct. > > As you might have noticed, we don't strictly follow the rules. Yes, I noticed. And what I'm saying is that perhaps you should follow the rules more

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 04:22:22PM +0200, Greg KH wrote: > On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > > On Thu 19-04-18 15:59:43, Greg KH wrote: > > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > > > On

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 04:22:22PM +0200, Greg KH wrote: > On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > > On Thu 19-04-18 15:59:43, Greg KH wrote: > > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > > > On

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 18:57, skrev Greg KH: On Thu, Apr 19, 2018 at 06:16:26PM +0300, Thomas Backlund wrote: Den 19.04.2018 kl. 17:22, skrev Greg KH: On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: On Thu 19-04-18 15:59:43, Greg KH wrote: On Thu, Apr 19, 2018 at 02:41:33PM +0300,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 18:57, skrev Greg KH: On Thu, Apr 19, 2018 at 06:16:26PM +0300, Thomas Backlund wrote: Den 19.04.2018 kl. 17:22, skrev Greg KH: On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: On Thu 19-04-18 15:59:43, Greg KH wrote: On Thu, Apr 19, 2018 at 02:41:33PM +0300,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 18:09, skrev Sasha Levin: On Thu, Apr 19, 2018 at 06:04:26PM +0300, Thomas Backlund wrote: Den 19.04.2018 kl. 16:59, skrev Greg KH: Anyway, we are trying not to do this, but it does, and will, occasionally happen. Look, we just did that for one platform for 4.9.94! And the

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 18:09, skrev Sasha Levin: On Thu, Apr 19, 2018 at 06:04:26PM +0300, Thomas Backlund wrote: Den 19.04.2018 kl. 16:59, skrev Greg KH: Anyway, we are trying not to do this, but it does, and will, occasionally happen. Look, we just did that for one platform for 4.9.94! And the

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 06:16:26PM +0300, Thomas Backlund wrote: > Den 19.04.2018 kl. 17:22, skrev Greg KH: > > On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > > > On Thu 19-04-18 15:59:43, Greg KH wrote: > > > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 06:16:26PM +0300, Thomas Backlund wrote: > Den 19.04.2018 kl. 17:22, skrev Greg KH: > > On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > > > On Thu 19-04-18 15:59:43, Greg KH wrote: > > > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 17:22, skrev Greg KH: On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: On Thu 19-04-18 15:59:43, Greg KH wrote: On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 17:22, skrev Greg KH: On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: On Thu 19-04-18 15:59:43, Greg KH wrote: On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 06:04:26PM +0300, Thomas Backlund wrote: >Den 19.04.2018 kl. 16:59, skrev Greg KH: >>Anyway, we are trying not to do this, but it does, and will, >>occasionally happen. Look, we just did that for one platform for >>4.9.94! And the key to all of this is good testing, which

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 06:04:26PM +0300, Thomas Backlund wrote: >Den 19.04.2018 kl. 16:59, skrev Greg KH: >>Anyway, we are trying not to do this, but it does, and will, >>occasionally happen. Look, we just did that for one platform for >>4.9.94! And the key to all of this is good testing, which

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 16:59, skrev Greg KH: On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: On Mon, 16 Apr 2018 16:02:03 + Sasha Levin

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 19.04.2018 kl. 16:59, skrev Greg KH: On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: On Mon, 16 Apr 2018 16:02:03 + Sasha Levin wrote: One of the things

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > On Thu 19-04-18 15:59:43, Greg KH wrote: > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 04:05:45PM +0200, Jan Kara wrote: > On Thu 19-04-18 15:59:43, Greg KH wrote: > > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu 19-04-18 15:59:43, Greg KH wrote: > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > > > On Mon, 16 Apr 2018 16:02:03 + > > > > Sasha Levin

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu 19-04-18 15:59:43, Greg KH wrote: > On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > > > On Mon, 16 Apr 2018 16:02:03 + > > > > Sasha Levin wrote:

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > > On Mon, 16 Apr 2018 16:02:03 + > > > Sasha Levin wrote: > > > > > > > One

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Thu, Apr 19, 2018 at 02:41:33PM +0300, Thomas Backlund wrote: > Den 16-04-2018 kl. 19:19, skrev Sasha Levin: > > On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: > > > On Mon, 16 Apr 2018 16:02:03 + > > > Sasha Levin wrote: > > > > > > > One of the things Greg is pushing

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: On Mon, 16 Apr 2018 16:02:03 + Sasha Levin wrote: One of the things Greg is pushing strongly for is "bug compatibility": we want the kernel to

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

Den 16-04-2018 kl. 19:19, skrev Sasha Levin: On Mon, Apr 16, 2018 at 12:12:24PM -0400, Steven Rostedt wrote: On Mon, 16 Apr 2018 16:02:03 + Sasha Levin wrote: One of the things Greg is pushing strongly for is "bug compatibility": we want the kernel to behave the same way between mainline

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 13:45:59, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 02:24:54PM +0200, Petr Mladek wrote: > >Back to the trend. Last week I got autosel mails even for > >patches that were still being discussed, had issues, and > >were far from upstream: > > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 13:45:59, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 02:24:54PM +0200, Petr Mladek wrote: > >Back to the trend. Last week I got autosel mails even for > >patches that were still being discussed, had issues, and > >were far from upstream: > > > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 07:57:54PM +0200, Jan Kara wrote: >Actually I was careful enough to include only commits that got merged as >part of the stable process into 4.14.x but got later reverted in 4.14.y. >That's where the 0.4% number came from. So I believe all of those cases >(13 in absolute

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 07:57:54PM +0200, Jan Kara wrote: >Actually I was careful enough to include only commits that got merged as >part of the stable process into 4.14.x but got later reverted in 4.14.y. >That's where the 0.4% number came from. So I believe all of those cases >(13 in absolute

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:36:44, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 04:22:46PM +0200, Michal Hocko wrote: > >On Tue 17-04-18 13:39:33, Sasha Levin wrote: > >[...] > >> But mm/ commits don't come only from these people. Here's a concrete > >> example we can discuss: > >> > >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:36:44, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 04:22:46PM +0200, Michal Hocko wrote: > >On Tue 17-04-18 13:39:33, Sasha Levin wrote: > >[...] > >> But mm/ commits don't come only from these people. Here's a concrete > >> example we can discuss: > >> > >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 16:19:35, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: > >> Even regression chance is tricky, look at the commits I've linked > >> earlier in the thread. Even the most trivial looking commits that end up > >> in stable have a chance for regression.

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 16:19:35, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: > >> Even regression chance is tricky, look at the commits I've linked > >> earlier in the thread. Even the most trivial looking commits that end up > >> in stable have a chance for regression.

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: >On Tue, 17 Apr 2018, Sasha Levin wrote: > >> How do I get the XFS folks to send their stuff to -stable? (we have >> quite a few customers who use XFS) > >If XFS (or *any* other subsystem) doesn't have enough manpower of upstream

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 05:52:30PM +0200, Jiri Kosina wrote: >On Tue, 17 Apr 2018, Sasha Levin wrote: > >> How do I get the XFS folks to send their stuff to -stable? (we have >> quite a few customers who use XFS) > >If XFS (or *any* other subsystem) doesn't have enough manpower of upstream

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 2018-04-17 at 17:52 +0200, Jiri Kosina wrote: > On Tue, 17 Apr 2018, Sasha Levin wrote: > > > How do I get the XFS folks to send their stuff to -stable? (we have > > quite a few customers who use XFS) > > If XFS (or *any* other subsystem) doesn't have enough manpower of upstream >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 2018-04-17 at 17:52 +0200, Jiri Kosina wrote: > On Tue, 17 Apr 2018, Sasha Levin wrote: > > > How do I get the XFS folks to send their stuff to -stable? (we have > > quite a few customers who use XFS) > > If XFS (or *any* other subsystem) doesn't have enough manpower of upstream >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: >On Tue 17-04-18 13:31:51, Sasha Levin wrote: >> We may be able to guesstimate the 'regression chance', but there's no >> way we can guess the 'annoyance' once. There are so many different use >> cases that we just can't even guess how many

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 05:55:49PM +0200, Jan Kara wrote: >On Tue 17-04-18 13:31:51, Sasha Levin wrote: >> We may be able to guesstimate the 'regression chance', but there's no >> way we can guess the 'annoyance' once. There are so many different use >> cases that we just can't even guess how many

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 13:31:51, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 01:41:44PM +0200, Jan Kara wrote: > >On Mon 16-04-18 17:23:30, Sasha Levin wrote: > >> On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: > >> >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: > >> >> On Mon, Apr 16,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 13:31:51, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 01:41:44PM +0200, Jan Kara wrote: > >On Mon 16-04-18 17:23:30, Sasha Levin wrote: > >> On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: > >> >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: > >> >> On Mon, Apr 16,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018, Sasha Levin wrote: > How do I get the XFS folks to send their stuff to -stable? (we have > quite a few customers who use XFS) If XFS (or *any* other subsystem) doesn't have enough manpower of upstream maintainers to deal with stable, we just have to accept that and find an

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018, Sasha Levin wrote: > How do I get the XFS folks to send their stuff to -stable? (we have > quite a few customers who use XFS) If XFS (or *any* other subsystem) doesn't have enough manpower of upstream maintainers to deal with stable, we just have to accept that and find an

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 04:36:31PM +0200, Michal Hocko wrote: >On Tue 17-04-18 14:04:36, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: >> >On Tue 17-04-18 12:39:36, Greg KH wrote: >> >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: >> >> > On

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 04:36:31PM +0200, Michal Hocko wrote: >On Tue 17-04-18 14:04:36, Sasha Levin wrote: >> On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: >> >On Tue 17-04-18 12:39:36, Greg KH wrote: >> >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: >> >> > On

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 04:22:46PM +0200, Michal Hocko wrote: >On Tue 17-04-18 13:39:33, Sasha Levin wrote: >[...] >> But mm/ commits don't come only from these people. Here's a concrete >> example we can discuss: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 04:22:46PM +0200, Michal Hocko wrote: >On Tue 17-04-18 13:39:33, Sasha Levin wrote: >[...] >> But mm/ commits don't come only from these people. Here's a concrete >> example we can discuss: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:04:36, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: > >On Tue 17-04-18 12:39:36, Greg KH wrote: > >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > >> > On Mon, 16 Apr 2018, Sasha Levin wrote: > >> > > >> > > I agree that as

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:04:36, Sasha Levin wrote: > On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: > >On Tue 17-04-18 12:39:36, Greg KH wrote: > >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > >> > On Mon, 16 Apr 2018, Sasha Levin wrote: > >> > > >> > > I agree that as

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 10:15:02AM -0400, Steven Rostedt wrote: > On Tue, 17 Apr 2018 14:04:36 + > Sasha Levin wrote: > > > The solution to this, in my opinion, is to automate the whole selection > > and review process. We do selection using AI, and we run

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 10:15:02AM -0400, Steven Rostedt wrote: > On Tue, 17 Apr 2018 14:04:36 + > Sasha Levin wrote: > > > The solution to this, in my opinion, is to automate the whole selection > > and review process. We do selection using AI, and we run every possible > > test that's

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 13:39:33, Sasha Levin wrote: [...] > But mm/ commits don't come only from these people. Here's a concrete > example we can discuss: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c61611f70958d86f659bca25c02ae69413747a8d I would be really

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 13:39:33, Sasha Levin wrote: [...] > But mm/ commits don't come only from these people. Here's a concrete > example we can discuss: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c61611f70958d86f659bca25c02ae69413747a8d I would be really

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018 14:04:36 + Sasha Levin wrote: > The solution to this, in my opinion, is to automate the whole selection > and review process. We do selection using AI, and we run every possible > test that's relevant to that subsystem. > > At which point,

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018 14:04:36 + Sasha Levin wrote: > The solution to this, in my opinion, is to automate the whole selection > and review process. We do selection using AI, and we run every possible > test that's relevant to that subsystem. > > At which point, the amount of work a human

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: >On Tue 17-04-18 12:39:36, Greg KH wrote: >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: >> > On Mon, 16 Apr 2018, Sasha Levin wrote: >> > >> > > I agree that as an enterprise distro taking everything from -stable >> >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 01:07:17PM +0200, Michal Hocko wrote: >On Tue 17-04-18 12:39:36, Greg KH wrote: >> On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: >> > On Mon, 16 Apr 2018, Sasha Levin wrote: >> > >> > > I agree that as an enterprise distro taking everything from -stable >> >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 02:24:54PM +0200, Petr Mladek wrote: >Back to the trend. Last week I got autosel mails even for >patches that were still being discussed, had issues, and >were far from upstream: > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 02:24:54PM +0200, Petr Mladek wrote: >Back to the trend. Last week I got autosel mails even for >patches that were still being discussed, had issues, and >were far from upstream: > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 02:49:24PM +0200, Michal Hocko wrote: >On Tue 17-04-18 14:24:54, Petr Mladek wrote: >[...] >> Back to the trend. Last week I got autosel mails even for >> patches that were still being discussed, had issues, and >> were far from upstream: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 02:49:24PM +0200, Michal Hocko wrote: >On Tue 17-04-18 14:24:54, Petr Mladek wrote: >[...] >> Back to the trend. Last week I got autosel mails even for >> patches that were still being discussed, had issues, and >> were far from upstream: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 01:41:44PM +0200, Jan Kara wrote: >On Mon 16-04-18 17:23:30, Sasha Levin wrote: >> On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: >> >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: >> >> On Mon, Apr 16, 2018 at 12:30:19PM -0400, Steven Rostedt wrote: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, Apr 17, 2018 at 01:41:44PM +0200, Jan Kara wrote: >On Mon 16-04-18 17:23:30, Sasha Levin wrote: >> On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: >> >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: >> >> On Mon, Apr 16, 2018 at 12:30:19PM -0400, Steven Rostedt wrote: >> >>

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:24:54, Petr Mladek wrote: [...] > Back to the trend. Last week I got autosel mails even for > patches that were still being discussed, had issues, and > were far from upstream: > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 14:24:54, Petr Mladek wrote: [...] > Back to the trend. Last week I got autosel mails even for > patches that were still being discussed, had issues, and > were far from upstream: > >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 12:46:37, Greg KH wrote: > Oh, I know why, suddenly subsystems that never were taking the time to > mark patches for stable are getting patches backported and are getting > nervous. Yes, I am getting nervous because of this. The number of printk fixes nominated for stable is

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 2018-04-17 12:46:37, Greg KH wrote: > Oh, I know why, suddenly subsystems that never were taking the time to > mark patches for stable are getting patches backported and are getting > nervous. Yes, I am getting nervous because of this. The number of printk fixes nominated for stable is

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon 16-04-18 17:23:30, Sasha Levin wrote: > On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: > >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: > >> On Mon, Apr 16, 2018 at 12:30:19PM -0400, Steven Rostedt wrote: > >> >On Mon, 16 Apr 2018 16:19:14 + > >> >Sasha Levin

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon 16-04-18 17:23:30, Sasha Levin wrote: > On Mon, Apr 16, 2018 at 07:06:04PM +0200, Pavel Machek wrote: > >On Mon 2018-04-16 16:37:56, Sasha Levin wrote: > >> On Mon, Apr 16, 2018 at 12:30:19PM -0400, Steven Rostedt wrote: > >> >On Mon, 16 Apr 2018 16:19:14 + > >> >Sasha Levin wrote: >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018, Greg KH wrote: > It already is that :) I have a question: I guess a stable team has an idea who they are preparing the tree for, IOW who is the target consumer. Who is it? Certainly it's not major distros, as both RH and SUSE already stated that they are either not basing

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue, 17 Apr 2018, Greg KH wrote: > It already is that :) I have a question: I guess a stable team has an idea who they are preparing the tree for, IOW who is the target consumer. Who is it? Certainly it's not major distros, as both RH and SUSE already stated that they are either not basing

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 12:39:36, Greg KH wrote: > On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > > On Mon, 16 Apr 2018, Sasha Levin wrote: > > > > > I agree that as an enterprise distro taking everything from -stable > > > isn't the best idea. Ideally you'd want to be close to the first

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Tue 17-04-18 12:39:36, Greg KH wrote: > On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > > On Mon, 16 Apr 2018, Sasha Levin wrote: > > > > > I agree that as an enterprise distro taking everything from -stable > > > isn't the best idea. Ideally you'd want to be close to the first

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 06:54:51PM +0200, Pavel Machek wrote: > On Mon 2018-04-16 16:45:16, Sasha Levin wrote: > > On Mon, Apr 16, 2018 at 06:42:30PM +0200, Pavel Machek wrote: > > >On Mon 2018-04-16 16:39:20, Sasha Levin wrote: > > >> On Mon, Apr 16, 2018 at 06:28:50PM +0200, Pavel Machek wrote:

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 06:54:51PM +0200, Pavel Machek wrote: > On Mon 2018-04-16 16:45:16, Sasha Levin wrote: > > On Mon, Apr 16, 2018 at 06:42:30PM +0200, Pavel Machek wrote: > > >On Mon 2018-04-16 16:39:20, Sasha Levin wrote: > > >> On Mon, Apr 16, 2018 at 06:28:50PM +0200, Pavel Machek wrote:

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 07:00:10PM +0200, Pavel Machek wrote: > Hi! > > > >> Let me ask my wife (who is happy using Linux as a regular desktop user) > > >> how comfortable she would be with triaging kernel bugs... > > > > > >That's really up to the distribution, not the main kernel stable. Does >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 07:00:10PM +0200, Pavel Machek wrote: > Hi! > > > >> Let me ask my wife (who is happy using Linux as a regular desktop user) > > >> how comfortable she would be with triaging kernel bugs... > > > > > >That's really up to the distribution, not the main kernel stable. Does >

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Sasha Levin wrote: > > > I agree that as an enterprise distro taking everything from -stable > > isn't the best idea. Ideally you'd want to be close to the first > > extreme you've mentioned and only take commits

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 11:28:44PM +0200, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Sasha Levin wrote: > > > I agree that as an enterprise distro taking everything from -stable > > isn't the best idea. Ideally you'd want to be close to the first > > extreme you've mentioned and only take commits

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018, Sasha Levin wrote: > I agree that as an enterprise distro taking everything from -stable > isn't the best idea. Ideally you'd want to be close to the first > extreme you've mentioned and only take commits if customers are asking > you to do so. > > I think that the rule

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018, Sasha Levin wrote: > I agree that as an enterprise distro taking everything from -stable > isn't the best idea. Ideally you'd want to be close to the first > extreme you've mentioned and only take commits if customers are asking > you to do so. > > I think that the rule

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018 13:17:24 -0700 Linus Torvalds wrote: > On Mon, Apr 16, 2018 at 1:02 PM, Steven Rostedt wrote: > > > > But this is going way off topic to what we were discussing. The > > discussion is about what gets backported. Is

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018 13:17:24 -0700 Linus Torvalds wrote: > On Mon, Apr 16, 2018 at 1:02 PM, Steven Rostedt wrote: > > > > But this is going way off topic to what we were discussing. The > > discussion is about what gets backported. Is automating the process > > going to make stable better? Or

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: >On Mon, 16 Apr 2018, Sasha Levin wrote: > >> So I think that Linus's claim that users come first applies here as >> well. If there's a user that cares about a particular feature being >> broken, then we go ahead and fix his bug rather

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, Apr 16, 2018 at 10:43:28PM +0200, Jiri Kosina wrote: >On Mon, 16 Apr 2018, Sasha Levin wrote: > >> So I think that Linus's claim that users come first applies here as >> well. If there's a user that cares about a particular feature being >> broken, then we go ahead and fix his bug rather

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018, Sasha Levin wrote: > So if a user is operating a nuclear power plant, and has 2 leds: green > one that says "All OK!" and a red one saying "NUCLEAR MELTDOWN!", and > once in a blue moon a race condition is causing the red one to go on and > cause panic in the little

Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes

On Mon, 16 Apr 2018, Sasha Levin wrote: > So if a user is operating a nuclear power plant, and has 2 leds: green > one that says "All OK!" and a red one saying "NUCLEAR MELTDOWN!", and > once in a blue moon a race condition is causing the red one to go on and > cause panic in the little

  1   2   3   >