Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-06 Thread Ian Campbell
On Thu, 2013-03-07 at 03:17 +, Will Deacon wrote: > > I looked and couldn't see an existing 64 bit xchg, was I looking in the > > wrong place? Ah, wait, I see atomic64_xchg now. But that needs an > > atomic64_t while I have a xen_ulong_t (which == 64 bits on ARM). This is > > a

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-06 Thread Will Deacon
Hi Ian, On Tue, Mar 05, 2013 at 09:29:57AM +, Ian Campbell wrote: > On Tue, 2013-03-05 at 08:08 +, Will Deacon wrote: > > Cheers Rob, that was enough to reproduce for me. The problem is likely that > > CONFIG_AEABI=n, so the ABI doesn't actually mandate even base registers for > > 64-bit

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-06 Thread Will Deacon
Hi Ian, On Tue, Mar 05, 2013 at 09:29:57AM +, Ian Campbell wrote: On Tue, 2013-03-05 at 08:08 +, Will Deacon wrote: Cheers Rob, that was enough to reproduce for me. The problem is likely that CONFIG_AEABI=n, so the ABI doesn't actually mandate even base registers for 64-bit values

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-06 Thread Ian Campbell
On Thu, 2013-03-07 at 03:17 +, Will Deacon wrote: I looked and couldn't see an existing 64 bit xchg, was I looking in the wrong place? Ah, wait, I see atomic64_xchg now. But that needs an atomic64_t while I have a xen_ulong_t (which == 64 bits on ARM). This is a kernel-hypervisor ABI

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 03:56:41AM +, Ian Campbell wrote: > > > diff --git a/arch/arm/include/asm/xen/events.h > > > b/arch/arm/include/asm/xen/events.h > > > index 94b4e90..5c27696 100644 > > > --- a/arch/arm/include/asm/xen/events.h > > > +++ b/arch/arm/include/asm/xen/events.h > > > @@

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Ian Campbell
On Tue, 2013-03-05 at 08:08 +, Will Deacon wrote: > Cheers Rob, that was enough to reproduce for me. The problem is likely that > CONFIG_AEABI=n, so the ABI doesn't actually mandate even base registers for > 64-bit values in registers. Me too. > Ian -- this would be fixed if you used our

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Will Deacon
On Tue, Mar 05, 2013 at 06:55:46AM +, Rob Herring wrote: > > I also can't immediately see why GCC would allocate oldval to an odd base > > register. Can you share your .config please? > > > > Here's a config: [...] Cheers Rob, that was enough to reproduce for me. The problem is likely that

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Will Deacon
On Tue, Mar 05, 2013 at 06:55:46AM +, Rob Herring wrote: I also can't immediately see why GCC would allocate oldval to an odd base register. Can you share your .config please? Here's a config: [...] Cheers Rob, that was enough to reproduce for me. The problem is likely that

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Ian Campbell
On Tue, 2013-03-05 at 08:08 +, Will Deacon wrote: Cheers Rob, that was enough to reproduce for me. The problem is likely that CONFIG_AEABI=n, so the ABI doesn't actually mandate even base registers for 64-bit values in registers. Me too. Ian -- this would be fixed if you used our

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 03:56:41AM +, Ian Campbell wrote: diff --git a/arch/arm/include/asm/xen/events.h b/arch/arm/include/asm/xen/events.h index 94b4e90..5c27696 100644 --- a/arch/arm/include/asm/xen/events.h +++ b/arch/arm/include/asm/xen/events.h @@ -15,4 +15,26 @@

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
On Tue, 2013-03-05 at 06:55 +, Rob Herring wrote: > Here's a config: Was it truncated? oldconfig is asking a ton of questions, far more than I would expect for something like variance between our HEADs etc. If I just answer the default to all the questions then I get a .config with Xen on

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Rob Herring
On 03/04/2013 09:04 PM, Will Deacon wrote: > Hi guys, > > On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: >> On 02/20/2013 05:48 AM, Ian Campbell wrote: >>> On ARM we want these to be the same size on 32- and 64-bit. >>> >>> This is an ABI change on ARM. X86 does not change. >>> >>>

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
> > diff --git a/arch/arm/include/asm/xen/events.h > > b/arch/arm/include/asm/xen/events.h > > index 94b4e90..5c27696 100644 > > --- a/arch/arm/include/asm/xen/events.h > > +++ b/arch/arm/include/asm/xen/events.h > > @@ -15,4 +15,26 @@ static inline int xen_irqs_disabled(struct pt_regs *regs) > >

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
On Tue, 2013-03-05 at 03:04 +, Will Deacon wrote: > Hi guys, > > On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: > > On 02/20/2013 05:48 AM, Ian Campbell wrote: > > > On ARM we want these to be the same size on 32- and 64-bit. > > > > > > This is an ABI change on ARM. X86 does

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Will Deacon
Hi guys, On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: > On 02/20/2013 05:48 AM, Ian Campbell wrote: > > On ARM we want these to be the same size on 32- and 64-bit. > > > > This is an ABI change on ARM. X86 does not change. > > > > Signed-off-by: Ian Campbell > > Cc: Jan Beulich

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Will Deacon
Hi guys, On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: On 02/20/2013 05:48 AM, Ian Campbell wrote: On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc:

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
On Tue, 2013-03-05 at 03:04 +, Will Deacon wrote: Hi guys, On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: On 02/20/2013 05:48 AM, Ian Campbell wrote: On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change.

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
diff --git a/arch/arm/include/asm/xen/events.h b/arch/arm/include/asm/xen/events.h index 94b4e90..5c27696 100644 --- a/arch/arm/include/asm/xen/events.h +++ b/arch/arm/include/asm/xen/events.h @@ -15,4 +15,26 @@ static inline int xen_irqs_disabled(struct pt_regs *regs) return

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Rob Herring
On 03/04/2013 09:04 PM, Will Deacon wrote: Hi guys, On Mon, Mar 04, 2013 at 02:45:33AM +, Rob Herring wrote: On 02/20/2013 05:48 AM, Ian Campbell wrote: On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-04 Thread Ian Campbell
On Tue, 2013-03-05 at 06:55 +, Rob Herring wrote: Here's a config: Was it truncated? oldconfig is asking a ton of questions, far more than I would expect for something like variance between our HEADs etc. If I just answer the default to all the questions then I get a .config with Xen on

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-03 Thread Rob Herring
On 02/20/2013 05:48 AM, Ian Campbell wrote: > On ARM we want these to be the same size on 32- and 64-bit. > > This is an ABI change on ARM. X86 does not change. > > Signed-off-by: Ian Campbell > Cc: Jan Beulich > Cc: Keir (Xen.org) > Cc: Tim Deegan > Cc: Stefano Stabellini > Cc:

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-03-03 Thread Rob Herring
On 02/20/2013 05:48 AM, Ian Campbell wrote: On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir (Xen.org) k...@xen.org Cc: Tim Deegan

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-21 Thread Stefano Stabellini
On Wed, 20 Feb 2013, Ian Campbell wrote: > On ARM we want these to be the same size on 32- and 64-bit. > > This is an ABI change on ARM. X86 does not change. > > Signed-off-by: Ian Campbell > Cc: Jan Beulich > Cc: Keir (Xen.org) > Cc: Tim Deegan > Cc: Stefano Stabellini > Cc:

Re: [PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-21 Thread Stefano Stabellini
On Wed, 20 Feb 2013, Ian Campbell wrote: On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir (Xen.org) k...@xen.org Cc: Tim Deegan

[PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-20 Thread Ian Campbell
On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian Campbell Cc: Jan Beulich Cc: Keir (Xen.org) Cc: Tim Deegan Cc: Stefano Stabellini Cc: linux-arm-ker...@lists.infradead.org Cc: xen-de...@lists.xen.org Cc: Konrad

[PATCH LINUX v5] xen: event channel arrays are xen_ulong_t and not unsigned long

2013-02-20 Thread Ian Campbell
On ARM we want these to be the same size on 32- and 64-bit. This is an ABI change on ARM. X86 does not change. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir (Xen.org) k...@xen.org Cc: Tim Deegan t...@xen.org Cc: Stefano Stabellini