答复: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi James, Thanks for your review and suggestion. > Hi gengdongjiu, > > On 08/12/17 04:43, gengdongjiu wrote: > > by the way, I think also change the info.si_code to "BUS_MCEERR_AR" is > > better, as shown [1]. > > BUS_MCEERR_AR can tell user space "Hardware memory error consumed on a > >

答复: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi James, Thanks for your review and suggestion. > Hi gengdongjiu, > > On 08/12/17 04:43, gengdongjiu wrote: > > by the way, I think also change the info.si_code to "BUS_MCEERR_AR" is > > better, as shown [1]. > > BUS_MCEERR_AR can tell user space "Hardware memory error consumed on a > >

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi gengdongjiu, On 08/12/17 04:43, gengdongjiu wrote: > by the way, I think also change the info.si_code to "BUS_MCEERR_AR" is > better, as shown [1]. > BUS_MCEERR_AR can tell user space "Hardware memory error consumed on a > error; action required". Today its also used as the last-resort.

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi gengdongjiu, On 08/12/17 04:43, gengdongjiu wrote: > by the way, I think also change the info.si_code to "BUS_MCEERR_AR" is > better, as shown [1]. > BUS_MCEERR_AR can tell user space "Hardware memory error consumed on a > error; action required". Today its also used as the last-resort.

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi James, Will On 2017/12/7 22:32, James Morse wrote: > Hi gengdongjiu, Will, > > On 07/12/17 05:55, gengdongjiu wrote: >> On 2017/12/7 0:15, Will Deacon wrote: --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr,

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi James, Will On 2017/12/7 22:32, James Morse wrote: > Hi gengdongjiu, Will, > > On 07/12/17 05:55, gengdongjiu wrote: >> On 2017/12/7 0:15, Will Deacon wrote: --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr,

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi gengdongjiu, Will, On 07/12/17 05:55, gengdongjiu wrote: > On 2017/12/7 0:15, Will Deacon wrote: >>> --- a/arch/arm64/mm/fault.c >>> +++ b/arch/arm64/mm/fault.c >>> @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr, unsigned int esr, >>> struct pt_regs *regs) >>> { >>> struct

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

Hi gengdongjiu, Will, On 07/12/17 05:55, gengdongjiu wrote: > On 2017/12/7 0:15, Will Deacon wrote: >>> --- a/arch/arm64/mm/fault.c >>> +++ b/arch/arm64/mm/fault.c >>> @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr, unsigned int esr, >>> struct pt_regs *regs) >>> { >>> struct

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

On 2017/12/7 0:15, Will Deacon wrote: >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr, unsigned int esr, >> struct pt_regs *regs) >> { >> struct siginfo info; >> const struct fault_info *inf; >> -int ret = 0;

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

On 2017/12/7 0:15, Will Deacon wrote: >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr, unsigned int esr, >> struct pt_regs *regs) >> { >> struct siginfo info; >> const struct fault_info *inf; >> -int ret = 0;

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

On Tue, Dec 05, 2017 at 11:02:35PM +0800, Dongjiu Geng wrote: > If APEI handling the memory error is failed, the do_mem_abort() > and do_sea() will all deliver SIGBUS. In fact, sending one time > can be enough, so correct it. > > Signed-off-by: Dongjiu Geng > --- >

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

On Tue, Dec 05, 2017 at 11:02:35PM +0800, Dongjiu Geng wrote: > If APEI handling the memory error is failed, the do_mem_abort() > and do_sea() will all deliver SIGBUS. In fact, sending one time > can be enough, so correct it. > > Signed-off-by: Dongjiu Geng > --- > arch/arm64/mm/fault.c | 5

[PATCH RESEND] arm64: fault: avoid send SIGBUS two times

If APEI handling the memory error is failed, the do_mem_abort() and do_sea() will all deliver SIGBUS. In fact, sending one time can be enough, so correct it. Signed-off-by: Dongjiu Geng --- arch/arm64/mm/fault.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH RESEND] arm64: fault: avoid send SIGBUS two times

If APEI handling the memory error is failed, the do_mem_abort() and do_sea() will all deliver SIGBUS. In fact, sending one time can be enough, so correct it. Signed-off-by: Dongjiu Geng --- arch/arm64/mm/fault.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git