Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Michael Grzeschik
On Mon, Dec 02, 2013 at 03:11:03PM +0400, Alexander Shiyan wrote: > > > > Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones : > > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > > If this driver being loaded

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Mon, 02 Dec 2013, Alexander Shiyan wrote: > > > > Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones : > > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > > If this driver being loaded from devicetree, the

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Alexander Shiyan
Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones : > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > If this driver being loaded from devicetree, the pdata is NULL. > > > > This cause kernel Oops when

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > If this driver being loaded from devicetree, the pdata is NULL. > > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > > > "fsl,mc13xxx-uses-touch" properties is

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Sat, 30 Nov 2013, Alexander Shiyan wrote: > If this driver being loaded from devicetree, the pdata is NULL. > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > "fsl,mc13xxx-uses-touch" properties is specified. The original code is pretty gross. This stuff shouldn't be

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Philippe Rétornaz
Le 30/11/2013 10:53, Alexander Shiyan a écrit : If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or "fsl,mc13xxx-uses-touch" properties is specified. Well, the codec and touch are not supported if DT is used, thus why

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Philippe Rétornaz
Le 30/11/2013 10:53, Alexander Shiyan a écrit : If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. Well, the codec and touch are not supported if DT is used, thus why

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Sat, 30 Nov 2013, Alexander Shiyan wrote: If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. snip The original code is pretty gross. This stuff shouldn't be identifying

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Sat, 30 Nov 2013, Alexander Shiyan wrote: On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified.

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Alexander Shiyan
Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones lee.jo...@linaro.org: On Sat, 30 Nov 2013, Alexander Shiyan wrote: On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Lee Jones
On Mon, 02 Dec 2013, Alexander Shiyan wrote: Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones lee.jo...@linaro.org: On Sat, 30 Nov 2013, Alexander Shiyan wrote: On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being loaded from devicetree,

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Michael Grzeschik
On Mon, Dec 02, 2013 at 03:11:03PM +0400, Alexander Shiyan wrote: Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones lee.jo...@linaro.org: On Sat, 30 Nov 2013, Alexander Shiyan wrote: On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being

[PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Alexander Shiyan
If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or "fsl,mc13xxx-uses-touch" properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 Unable to handle kernel NULL pointer dereference at virtual

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Alexander Shiyan
> On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > If this driver being loaded from devicetree, the pdata is NULL. > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > > "fsl,mc13xxx-uses-touch" properties is specified. > > > > mc13xxx spi0.0: mc13783: rev: 3.3,

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Michael Grzeschik
On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > If this driver being loaded from devicetree, the pdata is NULL. > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > "fsl,mc13xxx-uses-touch" properties is specified. > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab:

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Michael Grzeschik
On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid:

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Alexander Shiyan
On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0,

[PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Alexander Shiyan
If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 Unable to handle kernel NULL pointer dereference at virtual

[PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-29 Thread Alexander Shiyan
If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or "fsl,mc13xxx-uses-touch" properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 Unable to handle kernel NULL pointer dereference at virtual

[PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-29 Thread Alexander Shiyan
If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when fsl,mc13xxx-uses-codec and/or fsl,mc13xxx-uses-touch properties is specified. mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 Unable to handle kernel NULL pointer dereference at virtual