Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
On 2013/5/28 23:29, Andy Shevchenko wrote: > This is good fix, but I rather prefer not to see it in this shape. > See comments below. > > On Wed, May 22, 2013 at 6:51 AM, Libo Chen > wrote: >> >> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not >> its member. >> >>

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Andy Shevchenko
This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > > Signed-off-by: Libo Chen > Acked-by: Rafał Miłecki > --- >

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Rafał Miłecki
2013/5/28 Libo Chen : > ping... It takes a lot of time for someone to pick up mtd patches, just be patient ;) -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
ping... On 2013/5/22 11:51, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > > Signed-off-by: Libo Chen > Acked-by: Rafał Miłecki > --- > drivers/mtd/devices/bcm47xxsflash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
ping... On 2013/5/22 11:51, Libo Chen wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Rafał Miłecki
2013/5/28 Libo Chen clbchenlibo.c...@huawei.com: ping... It takes a lot of time for someone to pick up mtd patches, just be patient ;) -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Andy Shevchenko
This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
On 2013/5/28 23:29, Andy Shevchenko wrote: This is good fix, but I rather prefer not to see it in this shape. See comments below. On Wed, May 22, 2013 at 6:51 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Rafał Miłecki
2013/5/22 Libo Chen : > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. Thanks! -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Libo Chen
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen Acked-by: Rafał Miłecki --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki * change send list diff --git

[PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Libo Chen
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen libo.c...@huawei.com Acked-by: Rafał Miłecki zaj...@gmail.com --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Rafał Miłecki
2013/5/22 Libo Chen clbchenlibo.c...@huawei.com: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Thanks! -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More