Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-27 Thread Jean Delvare
On Thu, 26 Jan 2017 11:29:11 +0200, Mika Westerberg wrote: > On Thu, Jan 26, 2017 at 10:05:06AM +0100, Jean Delvare wrote: > > I have not, as I do not have access to any Baytrail hardware. This is > > the very reason why I'd like this code to be buildable as a module: I'm > > not happy with a

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-27 Thread Jean Delvare
On Thu, 26 Jan 2017 11:29:11 +0200, Mika Westerberg wrote: > On Thu, Jan 26, 2017 at 10:05:06AM +0100, Jean Delvare wrote: > > I have not, as I do not have access to any Baytrail hardware. This is > > the very reason why I'd like this code to be buildable as a module: I'm > > not happy with a

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 10:26:56AM +0100, Takashi Iwai wrote: > I guess it would break things on some machines if the module loading > order isn't setup properly. For example, it's known that > pinctrl-cherrytrail breaks MMC or others if it's loaded too lately. Yes, if you have rootfs on eMMC

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 10:26:56AM +0100, Takashi Iwai wrote: > I guess it would break things on some machines if the module loading > order isn't setup properly. For example, it's known that > pinctrl-cherrytrail breaks MMC or others if it's loaded too lately. Yes, if you have rootfs on eMMC

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 10:05:06AM +0100, Jean Delvare wrote: > Hi Mika and all, > > On Wed, 25 Jan 2017 18:16:51 +0200, Mika Westerberg wrote: > > On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > > > The pinctrl-baytrail driver builds just fine as a module so give > > > users this

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 10:05:06AM +0100, Jean Delvare wrote: > Hi Mika and all, > > On Wed, 25 Jan 2017 18:16:51 +0200, Mika Westerberg wrote: > > On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > > > The pinctrl-baytrail driver builds just fine as a module so give > > > users this

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Takashi Iwai
On Thu, 26 Jan 2017 10:19:31 +0100, Mika Westerberg wrote: > > On Thu, Jan 26, 2017 at 09:55:36AM +0100, Linus Walleij wrote: > > On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > > > > > The pinctrl-baytrail driver builds just fine as a module so give > > > users this

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Takashi Iwai
On Thu, 26 Jan 2017 10:19:31 +0100, Mika Westerberg wrote: > > On Thu, Jan 26, 2017 at 09:55:36AM +0100, Linus Walleij wrote: > > On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > > > > > The pinctrl-baytrail driver builds just fine as a module so give > > > users this option. > > > > > >

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 09:55:36AM +0100, Linus Walleij wrote: > On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > > > The pinctrl-baytrail driver builds just fine as a module so give > > users this option. > > > > Signed-off-by: Jean Delvare > > Cc:

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Mika Westerberg
On Thu, Jan 26, 2017 at 09:55:36AM +0100, Linus Walleij wrote: > On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > > > The pinctrl-baytrail driver builds just fine as a module so give > > users this option. > > > > Signed-off-by: Jean Delvare > > Cc: Mika Westerberg > > Cc: Heikki

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Jean Delvare
Hi Mika and all, On Wed, 25 Jan 2017 18:16:51 +0200, Mika Westerberg wrote: > On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > > The pinctrl-baytrail driver builds just fine as a module so give > > users this option. > > > > Signed-off-by: Jean Delvare > > Cc:

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Jean Delvare
Hi Mika and all, On Wed, 25 Jan 2017 18:16:51 +0200, Mika Westerberg wrote: > On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > > The pinctrl-baytrail driver builds just fine as a module so give > > users this option. > > > > Signed-off-by: Jean Delvare > > Cc: Mika Westerberg >

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Linus Walleij
On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Linus Walleij
On Wed, Jan 25, 2017 at 4:26 PM, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus > Cc: Linus Walleij > --- > This was discussed almost one year ago, with no

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Heikki Krogerus
On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-26 Thread Heikki Krogerus
On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus OK by me. FWIW. Reviewed-by: Heikki Krogerus Thanks, --

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Mika Westerberg
On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg Assuming you have checked that nothing

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Mika Westerberg
On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg Assuming you have checked that nothing breaks in Baytrail, I'm fine with this change,

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Andy Shevchenko
On Wed, Jan 25, 2017 at 5:26 PM, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus

Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Andy Shevchenko
On Wed, Jan 25, 2017 at 5:26 PM, Jean Delvare wrote: > The pinctrl-baytrail driver builds just fine as a module so give > users this option. > > Signed-off-by: Jean Delvare > Cc: Mika Westerberg > Cc: Heikki Krogerus > Cc: Linus Walleij Looks okay to me. FWIW: Reviewed-by: Andy Shevchenko

[PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Jean Delvare
The pinctrl-baytrail driver builds just fine as a module so give users this option. Signed-off-by: Jean Delvare Cc: Mika Westerberg Cc: Heikki Krogerus Cc: Linus Walleij --- This was

[PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

2017-01-25 Thread Jean Delvare
The pinctrl-baytrail driver builds just fine as a module so give users this option. Signed-off-by: Jean Delvare Cc: Mika Westerberg Cc: Heikki Krogerus Cc: Linus Walleij --- This was discussed almost one year ago, with no clear conclusion, but also no evidence that the driver can't be built