Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-03 Thread Ben Hutchings
On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote: > On 05/02, Andrew Morton wrote: > > > > > > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote: > > > > > > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-03 Thread Ben Hutchings
On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote: > On 05/02, Andrew Morton wrote: > > > > > > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote: > > > > > > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-03 Thread Oleg Nesterov
On 05/02, Andrew Morton wrote: > > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko > wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). We

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-03 Thread Oleg Nesterov
On 05/02, Andrew Morton wrote: > > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko > wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). We have

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-02 Thread Andrew Morton
On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote: > This patch has already been posted to LKML by Ben Hutchings ~6 months > ago, but AFAIK no further action were performed. However, this patch > really fixes weird loadavg with RTS5129 card reader, so I

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-02 Thread Andrew Morton
On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote: > This patch has already been posted to LKML by Ben Hutchings ~6 months > ago, but AFAIK no further action were performed. However, this patch > really fixes weird loadavg with RTS5129 card reader, so I would wonder > if this could

[PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-02 Thread Oleksandr Natalenko
This patch has already been posted to LKML by Ben Hutchings ~6 months ago, but AFAIK no further action were performed. However, this patch really fixes weird loadavg with RTS5129 card reader, so I would wonder if this could be merged. AFAIK, it has been applied to some distros' kernels, e.g.,

[PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2016-05-02 Thread Oleksandr Natalenko
This patch has already been posted to LKML by Ben Hutchings ~6 months ago, but AFAIK no further action were performed. However, this patch really fixes weird loadavg with RTS5129 card reader, so I would wonder if this could be merged. AFAIK, it has been applied to some distros' kernels, e.g.,

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-09 Thread Lee Jones
On Thu, 08 Oct 2015, Ben Hutchings wrote: > On Thu, 2015-10-08 at 08:19 +0100, Lee Jones wrote: > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the load average (for > > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-09 Thread Lee Jones
On Thu, 08 Oct 2015, Ben Hutchings wrote: > On Thu, 2015-10-08 at 08:19 +0100, Lee Jones wrote: > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the load average (for > > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-08 Thread Ben Hutchings
On Thu, 2015-10-08 at 08:19 +0100, Lee Jones wrote: > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). A load average of ~1 on a system

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-08 Thread Lee Jones
On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > > Change the

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-08 Thread Lee Jones
On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > > Change the

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-08 Thread Ben Hutchings
On Thu, 2015-10-08 at 08:19 +0100, Lee Jones wrote: > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). A load average of ~1 on a system

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-07 Thread Roger Tseng
On Mon, 2015-09-28 at 01:34 +0100, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-10-07 Thread Roger Tseng
On Mon, 2015-09-28 at 01:34 +0100, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Lee Jones
On Mon, 28 Sep 2015, Ben Hutchings wrote: > On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > > The subsystem is missing from the subject line. > > > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Ben Hutchings
On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > The subsystem is missing from the subject line. > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Lee Jones
The subsystem is missing from the subject line. On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Ben Hutchings
On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > The subsystem is missing from the subject line. > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > >

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Lee Jones
On Mon, 28 Sep 2015, Ben Hutchings wrote: > On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > > The subsystem is missing from the subject line. > > > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still

Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-28 Thread Lee Jones
The subsystem is missing from the subject line. On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should

[PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-27 Thread Ben Hutchings
rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. A

[PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

2015-09-27 Thread Ben Hutchings
rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. A