Re: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-26 Thread Yoshihiro YUNOMAE
To: Yoshihiro YUNOMAE Cc: Hannes Reinecke; Prarit Bhargava; linux-s...@vger.kernel.org; Kay Sievers; linux-kernel@vger.kernel.org; Hidehiro Kawai; yrl.pp- manager...@hitachi.com; Masami Hiramatsu Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line On Thu

Re: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-26 Thread Yoshihiro YUNOMAE
To: Yoshihiro YUNOMAE Cc: Hannes Reinecke; Prarit Bhargava; linux-s...@vger.kernel.org; Kay Sievers; linux-kernel@vger.kernel.org; Hidehiro Kawai; yrl.pp- manager...@hitachi.com; Masami Hiramatsu Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line On Thu

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-22 Thread Christoph Hellwig
On Wed, May 21, 2014 at 08:30:58AM +0200, Hannes Reinecke wrote: > While this works reasonably well for most things, printing out > decoded sense with just one line (and not end up in massive switch() > statements) is near impossible. > > Plus you'll end up having to use a static buffer at one

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-22 Thread Christoph Hellwig
On Wed, May 21, 2014 at 08:30:58AM +0200, Hannes Reinecke wrote: While this works reasonably well for most things, printing out decoded sense with just one line (and not end up in massive switch() statements) is near impossible. Plus you'll end up having to use a static buffer at one point,

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-21 Thread Hannes Reinecke
Bhargava; linux-s...@vger.kernel.org; Kay Sievers; linux-kernel@vger.kernel.org; Hidehiro Kawai; yrl.pp- manager...@hitachi.com; Masami Hiramatsu Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-21 Thread Hannes Reinecke
Bhargava; linux-s...@vger.kernel.org; Kay Sievers; linux-kernel@vger.kernel.org; Hidehiro Kawai; yrl.pp- manager...@hitachi.com; Masami Hiramatsu Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote

RE: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-20 Thread Elliott, Robert (Server Storage)
y > Sievers; linux-kernel@vger.kernel.org; Hidehiro Kawai; yrl.pp- > manager...@hitachi.com; Masami Hiramatsu > Subject: Re: [PATCH RESEND] scsi: Output error messages using structured > printk in single line > > On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote: &g

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-20 Thread James Bottomley
On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote: > +/* Maximum size of a local buffer for structured printk */ > +#define SCSI_LOG_LINE_MAX 512 > + > +/* Local buffer for structured printk */ > +struct scsi_log_line { > + int offset; > + char buf[SCSI_LOG_LINE_MAX]; > +}; This

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-20 Thread James Bottomley
On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote: +/* Maximum size of a local buffer for structured printk */ +#define SCSI_LOG_LINE_MAX 512 + +/* Local buffer for structured printk */ +struct scsi_log_line { + int offset; + char buf[SCSI_LOG_LINE_MAX]; +}; This piece

RE: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-20 Thread Elliott, Robert (Server Storage)
@vger.kernel.org; Hidehiro Kawai; yrl.pp- manager...@hitachi.com; Masami Hiramatsu Subject: Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote: +/* Maximum size of a local buffer for structured printk

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-02-26 Thread Yoshihiro YUNOMAE
Hi Hannes, Although I sent you a message 6 days ago to ask your work which is similar to my patch, I resend my patch because I'm considering this problem should be fixed as soon as possible. Thank you, Yoshihiro YUNOMAE (2014/02/27 13:17), Yoshihiro YUNOMAE wrote: Output error messages using

[PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-02-26 Thread Yoshihiro YUNOMAE
Output error messages using structured printk in single line. In SCSI drivers, some error messages which should be output in single line are divided in multiple lines. When user tools handle the error messages, those divided messages will create some inconveniences. The reason why this problem is

[PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-02-26 Thread Yoshihiro YUNOMAE
Output error messages using structured printk in single line. In SCSI drivers, some error messages which should be output in single line are divided in multiple lines. When user tools handle the error messages, those divided messages will create some inconveniences. The reason why this problem is

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-02-26 Thread Yoshihiro YUNOMAE
Hi Hannes, Although I sent you a message 6 days ago to ask your work which is similar to my patch, I resend my patch because I'm considering this problem should be fixed as soon as possible. Thank you, Yoshihiro YUNOMAE (2014/02/27 13:17), Yoshihiro YUNOMAE wrote: Output error messages using