Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-19 Thread Alessio Balsini
On Thu, Mar 18, 2021 at 10:15:43PM +0100, Arnd Bergmann wrote: > On Thu, Mar 18, 2021 at 5:13 PM Alessio Balsini wrote: > > On Tue, Mar 16, 2021 at 07:53:06PM +0100, Arnd Bergmann wrote: > > > On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini > > > wrote: > > > > > > > > Thanks for spotting this

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-18 Thread Arnd Bergmann
On Thu, Mar 18, 2021 at 5:13 PM Alessio Balsini wrote: > On Tue, Mar 16, 2021 at 07:53:06PM +0100, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini wrote: > > > > > Thanks for spotting this possible criticality. > > I noticed that 32-bit users pace was unable to use the >

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-18 Thread Alessio Balsini
On Tue, Mar 16, 2021 at 07:53:06PM +0100, Arnd Bergmann wrote: > On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini wrote: > > > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > > coming from 32-bit user space. > > This is due to the ioctl command translation that

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-16 Thread Arnd Bergmann
On Thu, Jan 28, 2021 at 3:17 PM Alessio Balsini wrote: > > Hi all, > > I'm more than happy to change the interface into something that is > objectively better and accepted by everyone. > I would really love to reach the point at which we have a "stable-ish" > UAPI as soon as possible. It's in

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-16 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini wrote: > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > coming from 32-bit user space. > This is due to the ioctl command translation that generates different > command identifiers that thus cannot be used for direct

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-01 Thread Alessio Balsini
On Wed, Feb 17, 2021 at 11:21:04AM +0100, Miklos Szeredi wrote: > On Mon, Jan 25, 2021 at 4:31 PM Alessio Balsini wrote: > > > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > > coming from 32-bit user space. > > This is due to the ioctl command translation that

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-02-17 Thread Miklos Szeredi
On Mon, Jan 25, 2021 at 4:31 PM Alessio Balsini wrote: > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > coming from 32-bit user space. > This is due to the ioctl command translation that generates different > command identifiers that thus cannot be used for direct

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-02-05 Thread Peng Tao
On Thu, Jan 28, 2021 at 10:15 PM Alessio Balsini wrote: > > Hi all, > > I'm more than happy to change the interface into something that is > objectively better and accepted by everyone. > I would really love to reach the point at which we have a "stable-ish" > UAPI as soon as possible. > > I've

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-01-28 Thread Alessio Balsini
Hi all, I'm more than happy to change the interface into something that is objectively better and accepted by everyone. I would really love to reach the point at which we have a "stable-ish" UAPI as soon as possible. I've been thinking about a few possible approaches to fix the issue, yet to

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-01-27 Thread Alessio Balsini
On Wed, Jan 27, 2021 at 08:15:19PM +0800, qxy wrote: > Hi Allesio, > > Thank you for your supply for 32-bit user space. > Actually we have already met this issue on our product and we resolved it > like this: > > Project *platform/external/libfuse* > diff --git a/include/fuse_kernel.h

[PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-01-25 Thread Alessio Balsini
With a 64-bit kernel build the FUSE device cannot handle ioctl requests coming from 32-bit user space. This is due to the ioctl command translation that generates different command identifiers that thus cannot be used for direct comparisons without proper manipulation. Explicitly extract type and