Re: [PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 08:48 AM, Lee Jones wrote: > > Looks okay to me, but I'd be happy with some more reviews from the > Chrome guys. I would especially like some knowledgeable type to > answer your EC_PROTO2_MAX_PARAM_SIZE question. If no one does, I > guess it can always be changed

Re: [PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 08:48 AM, Lee Jones wrote: Looks okay to me, but I'd be happy with some more reviews from the Chrome guys. I would especially like some knowledgeable type to answer your EC_PROTO2_MAX_PARAM_SIZE question. If no one does, I guess it can always be changed later.

Re: [PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-19 Thread Lee Jones
On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: > The struct cros_ec_command will be used as an ioctl() argument for the > API to control the ChromeOS EC from user-space. So the data structure > has to be 64-bit safe to make it compatible between 32 and 64 avoiding > the need for a compat

Re: [PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-19 Thread Lee Jones
On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: The struct cros_ec_command will be used as an ioctl() argument for the API to control the ChromeOS EC from user-space. So the data structure has to be 64-bit safe to make it compatible between 32 and 64 avoiding the need for a compat ioctl

[PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-02 Thread Javier Martinez Canillas
The struct cros_ec_command will be used as an ioctl() argument for the API to control the ChromeOS EC from user-space. So the data structure has to be 64-bit safe to make it compatible between 32 and 64 avoiding the need for a compat ioctl interface. Since pointers are self-aligned to different

[PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-02 Thread Javier Martinez Canillas
The struct cros_ec_command will be used as an ioctl() argument for the API to control the ChromeOS EC from user-space. So the data structure has to be 64-bit safe to make it compatible between 32 and 64 avoiding the need for a compat ioctl interface. Since pointers are self-aligned to different