Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-09 Thread Heiher
Hi, On Tue, Oct 8, 2019 at 3:10 AM Roman Penyaev wrote: > > On 2019-10-07 20:43, Jason Baron wrote: > > On 10/7/19 2:30 PM, Roman Penyaev wrote: > >> On 2019-10-07 18:42, Jason Baron wrote: > >>> On 10/7/19 6:54 AM, Roman Penyaev wrote: > On 2019-10-03 18:13, Jason Baron wrote: > > On

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-08 Thread Roman Penyaev
On 2019-10-07 20:43, Jason Baron wrote: [...] But what if to make this wakeup explicit if we have more events to process? (nothing is tested, just a guess) @@ -255,6 +255,7 @@ struct ep_pqueue {  struct ep_send_events_data {     int maxevents;     struct epoll_event __user *events; + 

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-07 Thread Roman Penyaev
On 2019-10-07 20:43, Jason Baron wrote: On 10/7/19 2:30 PM, Roman Penyaev wrote: On 2019-10-07 18:42, Jason Baron wrote: On 10/7/19 6:54 AM, Roman Penyaev wrote: On 2019-10-03 18:13, Jason Baron wrote: On 9/30/19 7:55 AM, Roman Penyaev wrote: On 2019-09-28 04:29, Andrew Morton wrote: On

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-07 Thread Jason Baron
On 10/7/19 2:30 PM, Roman Penyaev wrote: > On 2019-10-07 18:42, Jason Baron wrote: >> On 10/7/19 6:54 AM, Roman Penyaev wrote: >>> On 2019-10-03 18:13, Jason Baron wrote: On 9/30/19 7:55 AM, Roman Penyaev wrote: > On 2019-09-28 04:29, Andrew Morton wrote: >> On Wed, 25 Sep 2019

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-07 Thread Roman Penyaev
On 2019-10-07 18:42, Jason Baron wrote: On 10/7/19 6:54 AM, Roman Penyaev wrote: On 2019-10-03 18:13, Jason Baron wrote: On 9/30/19 7:55 AM, Roman Penyaev wrote: On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: From: Heiher Take the case where we

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-07 Thread Jason Baron
On 10/7/19 6:54 AM, Roman Penyaev wrote: > On 2019-10-03 18:13, Jason Baron wrote: >> On 9/30/19 7:55 AM, Roman Penyaev wrote: >>> On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: > From: Heiher > > Take the case where we have:

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-07 Thread Roman Penyaev
On 2019-10-03 18:13, Jason Baron wrote: On 9/30/19 7:55 AM, Roman Penyaev wrote: On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: From: Heiher Take the case where we have:     t0 | (ew)     e0 | (et)     e1 |

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-10-03 Thread Jason Baron
On 9/30/19 7:55 AM, Roman Penyaev wrote: > On 2019-09-28 04:29, Andrew Morton wrote: >> On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: >> >>> From: Heiher >>> >>> Take the case where we have: >>> >>>     t0 >>> | (ew) >>>     e0 >>> | (et) >>>     e1 >>>

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-30 Thread Roman Penyaev
On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: From: Heiher Take the case where we have: t0 | (ew) e0 | (et) e1 | (lt) s0 t0: thread 0 e0: epoll fd 0 e1: epoll fd 1 s0: socket fd 0 ew:

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-28 Thread Roman Penyaev
On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: From: Heiher Take the case where we have: t0 | (ew) e0 | (et) e1 | (lt) s0 t0: thread 0 e0: epoll fd 0 e1: epoll fd 1 s0: socket fd 0 ew:

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-27 Thread Andrew Morton
On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: > From: Heiher > > Take the case where we have: > > t0 > | (ew) > e0 > | (et) > e1 > | (lt) > s0 > > t0: thread 0 > e0: epoll fd 0 > e1: epoll fd 1 > s0: socket fd 0 > ew: epoll_wait >

[PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-24 Thread hev
From: Heiher Take the case where we have: t0 | (ew) e0 | (et) e1 | (lt) s0 t0: thread 0 e0: epoll fd 0 e1: epoll fd 1 s0: socket fd 0 ew: epoll_wait et: edge-trigger lt: level-trigger We only need to wakeup nested epoll fds if