Re: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Zhouyi Zhou
Thanks Jesper and David for reviewing and replying. Great commitment of Jesper for moving above three hlist_nulls_heads to percpu structure. Sorry to miss the newest advances in nf-next. And arbitrarily cache-line aligning structure members is not a good idea for large cache lines. Still I have

RE: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread David Laight
From: Zhouyi Zhou > not frequently changing components should share same cachelines > > Signed-off-by: Zhouyi Zhou > --- > include/net/netns/conntrack.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/include/net/netns/conntrack.h

Re: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Jesper Dangaard Brouer
On Wed, 12 Mar 2014 15:56:34 +0800 Zhouyi Zhou wrote: > not frequently changing components should share same cachelines > > Signed-off-by: Zhouyi Zhou > --- > include/net/netns/conntrack.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) NACK because I have already

[PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Zhouyi Zhou
not frequently changing components should share same cachelines Signed-off-by: Zhouyi Zhou --- include/net/netns/conntrack.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/include/net/netns/conntrack.h b/include/net/netns/conntrack.h index fbcc7fa..69d2d58

[PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Zhouyi Zhou
not frequently changing components should share same cachelines Signed-off-by: Zhouyi Zhou yizhouz...@ict.ac.cn --- include/net/netns/conntrack.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/include/net/netns/conntrack.h b/include/net/netns/conntrack.h index

Re: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Jesper Dangaard Brouer
On Wed, 12 Mar 2014 15:56:34 +0800 Zhouyi Zhou zhouzho...@gmail.com wrote: not frequently changing components should share same cachelines Signed-off-by: Zhouyi Zhou yizhouz...@ict.ac.cn --- include/net/netns/conntrack.h | 12 1 file changed, 8 insertions(+), 4 deletions(-)

RE: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread David Laight
From: Zhouyi Zhou not frequently changing components should share same cachelines Signed-off-by: Zhouyi Zhou yizhouz...@ict.ac.cn --- include/net/netns/conntrack.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/include/net/netns/conntrack.h

Re: [PATCH RFC] netfilter: cacheline aligning in struct netns_ct

2014-03-12 Thread Zhouyi Zhou
Thanks Jesper and David for reviewing and replying. Great commitment of Jesper for moving above three hlist_nulls_heads to percpu structure. Sorry to miss the newest advances in nf-next. And arbitrarily cache-line aligning structure members is not a good idea for large cache lines. Still I have