Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-20 Thread Konstantin Khlebnikov
On Fri, Jan 16, 2015 at 4:18 PM, Константин Хлебников wrote: > 16.01.2015, 04:16, "Andrew Morton" : >> On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov >> wrote: >>> This patch replaces cancel_dirty_page() with helper account_page_cleared() >>> which only updates counters. It's called

Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-20 Thread Konstantin Khlebnikov
On Fri, Jan 16, 2015 at 4:18 PM, Константин Хлебников khlebni...@yandex-team.ru wrote: 16.01.2015, 04:16, Andrew Morton a...@linux-foundation.org: On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov khlebni...@yandex-team.ru wrote: This patch replaces cancel_dirty_page() with helper

Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-16 Thread Константин Хлебников
16.01.2015, 04:16, "Andrew Morton" : > On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov > wrote: >>  This patch replaces cancel_dirty_page() with helper account_page_cleared() >>  which only updates counters. It's called from delete_from_page_cache() >>  and from try_to_free_buffers()

Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-16 Thread Константин Хлебников
16.01.2015, 04:16, Andrew Morton a...@linux-foundation.org: On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov khlebni...@yandex-team.ru wrote:  This patch replaces cancel_dirty_page() with helper account_page_cleared()  which only updates counters. It's called from

Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-15 Thread Andrew Morton
On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov wrote: > This patch replaces cancel_dirty_page() with helper account_page_cleared() > which only updates counters. It's called from delete_from_page_cache() > and from try_to_free_buffers() (hack for ext3). Page is locked in both cases. >

[PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-15 Thread Konstantin Khebnikov
This patch replaces cancel_dirty_page() with helper account_page_cleared() which only updates counters. It's called from delete_from_page_cache() and from try_to_free_buffers() (hack for ext3). Page is locked in both cases. Hugetlbfs has no dirty pages accounting, ClearPageDirty() is enough here.

[PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-15 Thread Konstantin Khebnikov
This patch replaces cancel_dirty_page() with helper account_page_cleared() which only updates counters. It's called from delete_from_page_cache() and from try_to_free_buffers() (hack for ext3). Page is locked in both cases. Hugetlbfs has no dirty pages accounting, ClearPageDirty() is enough here.

Re: [PATCH RFC] page_writeback: cleanup mess around cancel_dirty_page()

2015-01-15 Thread Andrew Morton
On Thu, 15 Jan 2015 18:57:31 +0300 Konstantin Khebnikov khlebni...@yandex-team.ru wrote: This patch replaces cancel_dirty_page() with helper account_page_cleared() which only updates counters. It's called from delete_from_page_cache() and from try_to_free_buffers() (hack for ext3). Page is