Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-04-15 Thread Felipe Balbi
Hi, On Tue, Apr 15, 2014 at 01:55:38PM -0400, Alan Stern wrote: > On Tue, 15 Apr 2014, Felipe Balbi wrote: > > > > 2. Does device need to know OUT transactions before hand so that OUT > > > requests are queued for endpoint before packets are received > > > from host? > > > > well, no. Gadget dri

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-04-15 Thread Alan Stern
On Tue, 15 Apr 2014, Felipe Balbi wrote: > > 2. Does device need to know OUT transactions before hand so that OUT > > requests are queued for endpoint before packets are received > > from host? > > well, no. Gadget driver shouldn't depend on that. That's UDC driver's > responsability to manage th

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-04-15 Thread Felipe Balbi
Hi, On Wed, Mar 26, 2014 at 03:37:52PM +0530, sundeep subbaraya wrote: > >> + INIT_LIST_HEAD(&req->queue); > > > > remove this INIT_LIST_HEAD(); > > > > also, before returning, I suppose you probably want to link the request > > to the endpoint somehow. Usually people save the endpoint pointer

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-03-10 Thread Felipe Balbi
Hi, On Mon, Mar 10, 2014 at 07:06:19PM +0530, sundeep subbaraya wrote: > On Fri, Feb 21, 2014 at 9:09 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Feb 21, 2014 at 11:27:07AM +, Subbaraya Sundeep Bhatta wrote: > >> > From the looks of it, I doubt this was actually tested, you need a lot > >

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-03-10 Thread sundeep subbaraya
On Fri, Feb 21, 2014 at 9:09 PM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 21, 2014 at 11:27:07AM +, Subbaraya Sundeep Bhatta wrote: >> > From the looks of it, I doubt this was actually tested, you need a lot >> > of work on this driver. >> Tested on both ARM and Microblaze architectures with

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: > On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: > > On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: > >> BTW: u-boot started to use SPDX-License-Identifier > >> which will be nice to start to use. > > > > I agree, feel

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Arnd Bergmann
On Friday 21 February 2014 16:51:07 Michal Simek wrote: > > | > > | if (res->flags & IORESOURCE_CACHEABLE) > > | dest_ptr = devm_ioremap(dev, res->start, size); > > | else > > | dest_ptr = devm_ioremap_nocache(dev, res->start, size); > > I have read it just not sur

SPDX-License-Identifier (was: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support)

2014-02-21 Thread Felipe Balbi
On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: > On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: > > On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: > >> BTW: u-boot started to use SPDX-License-Identifier > >> which will be nice to start to use. > > > > I agree, feel

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 03:41:03PM +, Felipe Balbi wrote: > Hi, > > On Fri, Feb 21, 2014 at 12:04:54PM +, Mark Rutland wrote: > > > > +Example: > > > > + axi-usb2-device@42e0 { > > > > +compatible = "xlnx,axi-usb2-device-4.00.a"; > > > > +

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
On Fri, Feb 21, 2014 at 04:51:07PM +0100, Michal Simek wrote: > On 02/21/2014 04:42 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: > > + /* Map the registers */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: >> BTW: u-boot started to use SPDX-License-Identifier >> which will be nice to start to use. > > I agree, feel free to start sending patches to use this type of > identifier for driver

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: > BTW: u-boot started to use SPDX-License-Identifier > which will be nice to start to use. I agree, feel free to start sending patches to use this type of identifier for drivers. greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
On 02/21/2014 04:42 PM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: > + /* Map the registers */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start, > +

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 12:04:54PM +, Mark Rutland wrote: > > > +Example: > > > + axi-usb2-device@42e0 { > > > +compatible = "xlnx,axi-usb2-device-4.00.a"; > > > +interrupt-parent = <0x1>; > > > +in

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: > >>> + /* Map the registers */ > >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >>> + udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start, > >>> + resource_size(re

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 11:27:07AM +, Subbaraya Sundeep Bhatta wrote: > > From the looks of it, I doubt this was actually tested, you need a lot > > of work on this driver. > Tested on both ARM and Microblaze architectures with Mass storage gadget. > Will send a v2 after addressing all you

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
>> If we can point to standard interrupt description then please point me to >> exact description you would like to see here and we can change it. > > Unfortunately I'm not aware of a generic interrupts document. I just > don't see the point in each document listing interrupt-parent as a > require

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 01:41:03PM +, Michal Simek wrote: > Hi Mark, > > On 02/21/2014 01:04 PM, Mark Rutland wrote: > > > > On Thu, Feb 20, 2014 at 06:23:13PM +, Felipe Balbi wrote: > >> Hi, > >> > >> On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote: > >>> This pa

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
Hi Mark, On 02/21/2014 01:04 PM, Mark Rutland wrote: > > On Thu, Feb 20, 2014 at 06:23:13PM +, Felipe Balbi wrote: >> Hi, >> >> On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote: >>> This patch adds xilinx axi usb2 device driver support >>> >>> Signed-off-by: Subbaraya

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 06:23:13PM +, Felipe Balbi wrote: > Hi, > > On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote: > > This patch adds xilinx axi usb2 device driver support > > > > Signed-off-by: Subbaraya Sundeep Bhatta > > --- > > .../devicetree/bindings/usb/xi

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-20 Thread Michal Simek
Hi, >> + * Copyright (C) 2010 - 2014 Xilinx, Inc. >> + * >> + * Some parts of this driver code is based on the driver for at91-series >> + * USB peripheral controller (at91_udc.c). >> + * >> + * This program is free software; you can redistribute it >> + * and/or modify it under the terms of the G

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-20 Thread Felipe Balbi
Hi, On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote: > This patch adds xilinx axi usb2 device driver support > > Signed-off-by: Subbaraya Sundeep Bhatta > --- > .../devicetree/bindings/usb/xilinx_usb.txt | 21 + > drivers/usb/gadget/Kconfig