Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-21 Thread Konrad Rzeszutek Wilk
On Fri, Mar 08, 2013 at 06:07:08PM +0100, Roger Pau Monné wrote: > On 05/03/13 22:46, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: > >> On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: > >>> On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-21 Thread Konrad Rzeszutek Wilk
On Fri, Mar 08, 2013 at 06:07:08PM +0100, Roger Pau Monné wrote: On 05/03/13 22:46, Konrad Rzeszutek Wilk wrote: On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote:

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-19 Thread Konrad Rzeszutek Wilk
On Mon, Mar 18, 2013 at 06:06:38PM +0100, Roger Pau Monné wrote: > On 28/02/13 11:28, Roger Pau Monne wrote: > > Indirect descriptors introduce a new block operation > > (BLKIF_OP_INDIRECT) that passes grant references instead of segments > > in the request. This grant references are filled with

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-19 Thread Konrad Rzeszutek Wilk
On Mon, Mar 18, 2013 at 06:06:38PM +0100, Roger Pau Monné wrote: On 28/02/13 11:28, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with arrays

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-18 Thread Roger Pau Monné
On 28/02/13 11:28, Roger Pau Monne wrote: > Indirect descriptors introduce a new block operation > (BLKIF_OP_INDIRECT) that passes grant references instead of segments > in the request. This grant references are filled with arrays of > blkif_request_segment_aligned, this way we can send more

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-18 Thread Roger Pau Monné
On 28/02/13 11:28, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with arrays of blkif_request_segment_aligned, this way we can send more segments

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-08 Thread Roger Pau Monné
On 05/03/13 22:46, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: >> On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: >>> On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-08 Thread Roger Pau Monné
On 05/03/13 22:46, Konrad Rzeszutek Wilk wrote: On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: > On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: > >> Indirect descriptors introduce a new block operation > >> (BLKIF_OP_INDIRECT) that passes grant references

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 06:00:51PM +0100, Roger Pau Monné wrote: > On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > > On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > > wrote: > >>> 'op' sounds good. With a comment saying it

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Roger Pau Monné
On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: >> Indirect descriptors introduce a new block operation >> (BLKIF_OP_INDIRECT) that passes grant references instead of segments >> in the request. This grant references are filled

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Roger Pau Monné
On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > wrote: >>> 'op' sounds good. With a comment saying it can do all of the >>> BLKIF_OPS_.. >>> except the BLKIF_OP_INDIRECT one.

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > >>> On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > >>> wrote: > > 'op' sounds good. With a comment saying it can do all of the > > BLKIF_OPS_.. > > except the BLKIF_OP_INDIRECT one. Thought one could in theory chain > > it that way

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Jan Beulich
>>> On 04.03.13 at 21:44, Konrad Rzeszutek Wilk wrote: > 'op' sounds good. With a comment saying it can do all of the > BLKIF_OPS_.. > except the BLKIF_OP_INDIRECT one. Thought one could in theory chain > it that way for fun. In fact I'd like to exclude chaining as well as BLKIF_OP_DISCARD

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Jan Beulich
On 04.03.13 at 21:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: nods 'op' sounds good. With a comment saying it can do all of the BLKIF_OPS_.. except the BLKIF_OP_INDIRECT one. Thought one could in theory chain it that way for fun. In fact I'd like to exclude chaining as well as

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: On 04.03.13 at 21:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: nods 'op' sounds good. With a comment saying it can do all of the BLKIF_OPS_.. except the BLKIF_OP_INDIRECT one. Thought one could in theory chain it

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Roger Pau Monné
On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: On 04.03.13 at 21:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: nods 'op' sounds good. With a comment saying it can do all of the BLKIF_OPS_.. except the BLKIF_OP_INDIRECT

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Roger Pau Monné
On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 06:00:51PM +0100, Roger Pau Monné wrote: On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: On 04.03.13 at 21:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: nods 'op' sounds good. With a comment

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 06:07:57PM +0100, Roger Pau Monné wrote: On 04/03/13 21:41, Konrad Rzeszutek Wilk wrote: On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 01:28:48PM +, Jan Beulich wrote: > >>> On 28.02.13 at 13:00, Roger Pau Monné wrote: > > On 28/02/13 12:19, Jan Beulich wrote: > > On 28.02.13 at 11:28, Roger Pau Monne wrote: > >>> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; > >>> */ > >>> #define

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: > Indirect descriptors introduce a new block operation > (BLKIF_OP_INDIRECT) that passes grant references instead of segments > in the request. This grant references are filled with arrays of > blkif_request_segment_aligned, this way

Re: [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 11:28:55AM +0100, Roger Pau Monne wrote: Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with arrays of blkif_request_segment_aligned, this way we

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 01:28:48PM +, Jan Beulich wrote: On 28.02.13 at 13:00, Roger Pau Monnéroger@citrix.com wrote: On 28/02/13 12:19, Jan Beulich wrote: On 28.02.13 at 11:28, Roger Pau Monne roger@citrix.com wrote: @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; */

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
>>> On 28.02.13 at 13:00, Roger Pau Monné wrote: > On 28/02/13 12:19, Jan Beulich wrote: > On 28.02.13 at 11:28, Roger Pau Monne wrote: >>> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; >>> */ >>> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 >>> >>> +#define

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Roger Pau Monné
On 28/02/13 12:19, Jan Beulich wrote: On 28.02.13 at 11:28, Roger Pau Monne wrote: >> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; >> */ >> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 >> >> +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 >> + >> +struct

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
>>> On 28.02.13 at 11:28, Roger Pau Monne wrote: > @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; > */ > #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 > > +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 > + > +struct blkif_request_segment_aligned { > + grant_ref_t gref;/*

[PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Roger Pau Monne
Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with arrays of blkif_request_segment_aligned, this way we can send more segments in a request. The proposed implementation

[PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Roger Pau Monne
Indirect descriptors introduce a new block operation (BLKIF_OP_INDIRECT) that passes grant references instead of segments in the request. This grant references are filled with arrays of blkif_request_segment_aligned, this way we can send more segments in a request. The proposed implementation

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
On 28.02.13 at 11:28, Roger Pau Monne roger@citrix.com wrote: @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; */ #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 + +struct blkif_request_segment_aligned { + grant_ref_t gref;

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Roger Pau Monné
On 28/02/13 12:19, Jan Beulich wrote: On 28.02.13 at 11:28, Roger Pau Monne roger@citrix.com wrote: @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; */ #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 + +struct

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
On 28.02.13 at 13:00, Roger Pau Monnéroger@citrix.com wrote: On 28/02/13 12:19, Jan Beulich wrote: On 28.02.13 at 11:28, Roger Pau Monne roger@citrix.com wrote: @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; */ #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 +#define