Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-19 Thread Tomasz Figa
Hi Tushar, On 19.05.2014 09:16, Tushar Behera wrote: > On 05/15/2014 11:02 PM, Tomasz Figa wrote: >> This patch introduces a driver that handles configuration of CLKOUT pin >> of Exynos SoCs that can be used to output certain clocks from inside of >> the SoC to a dedicated output pin. >> >>

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-19 Thread Tushar Behera
On 05/15/2014 11:02 PM, Tomasz Figa wrote: > This patch introduces a driver that handles configuration of CLKOUT pin > of Exynos SoCs that can be used to output certain clocks from inside of > the SoC to a dedicated output pin. > > Signed-off-by: Tomasz Figa > --- Tested the series on

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-19 Thread Tushar Behera
On 05/15/2014 11:02 PM, Tomasz Figa wrote: This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa t.f...@samsung.com --- Tested the series

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-19 Thread Tomasz Figa
Hi Tushar, On 19.05.2014 09:16, Tushar Behera wrote: On 05/15/2014 11:02 PM, Tomasz Figa wrote: This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by:

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-15 10:32:30) > This patch introduces a driver that handles configuration of CLKOUT pin > of Exynos SoCs that can be used to output certain clocks from inside of > the SoC to a dedicated output pin. > > Signed-off-by: Tomasz Figa Overall implementation looks good to

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:35, Rahul Sharma wrote: > On 16 May 2014 16:22, Tomasz Figa wrote: >> Hi Rahul, >> >> On 16.05.2014 12:39, Rahul Sharma wrote: >>> [snip] + gate->lock = _lock; + + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; + mux->mask = EXYNOS_CLKOUT_MUX_MASK;

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:22, Tomasz Figa wrote: > Hi Rahul, > > On 16.05.2014 12:39, Rahul Sharma wrote: >> [snip] >>> + gate->lock = _lock; >>> + >>> + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; >>> + mux->mask = EXYNOS_CLKOUT_MUX_MASK; >>> + mux->shift = EXYNOS_CLKOUT_MUX_SHIFT;

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: > [snip] >> + gate->lock = _lock; >> + >> + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; >> + mux->mask = EXYNOS_CLKOUT_MUX_MASK; >> + mux->shift = EXYNOS_CLKOUT_MUX_SHIFT; >> + mux->lock = _lock; >> + >> + clk =

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
[snip] > + gate->lock = _lock; > + > + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; > + mux->mask = EXYNOS_CLKOUT_MUX_MASK; > + mux->shift = EXYNOS_CLKOUT_MUX_SHIFT; > + mux->lock = _lock; > + > + clk = clk_register_composite(NULL, "clkout", parent_names, > +

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
[snip] + gate-lock = clkout_lock; + + mux-reg = reg + EXYNOS_PMU_DEBUG_REG; + mux-mask = EXYNOS_CLKOUT_MUX_MASK; + mux-shift = EXYNOS_CLKOUT_MUX_SHIFT; + mux-lock = clkout_lock; + + clk = clk_register_composite(NULL, clkout, parent_names, +

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: [snip] + gate-lock = clkout_lock; + + mux-reg = reg + EXYNOS_PMU_DEBUG_REG; + mux-mask = EXYNOS_CLKOUT_MUX_MASK; + mux-shift = EXYNOS_CLKOUT_MUX_SHIFT; + mux-lock = clkout_lock; + + clk =

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:22, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: [snip] + gate-lock = clkout_lock; + + mux-reg = reg + EXYNOS_PMU_DEBUG_REG; + mux-mask = EXYNOS_CLKOUT_MUX_MASK; + mux-shift = EXYNOS_CLKOUT_MUX_SHIFT; +

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:35, Rahul Sharma wrote: On 16 May 2014 16:22, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: [snip] + gate-lock = clkout_lock; + + mux-reg = reg + EXYNOS_PMU_DEBUG_REG; + mux-mask = EXYNOS_CLKOUT_MUX_MASK; +

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-15 10:32:30) This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa t.f...@samsung.com Overall implementation

[PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-15 Thread Tomasz Figa
This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa --- .../devicetree/bindings/arm/samsung/pmu.txt| 18

[PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-15 Thread Tomasz Figa
This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa t.f...@samsung.com --- .../devicetree/bindings/arm/samsung/pmu.txt| 18