Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-11-03 Thread Ludovic Desroches
On Fri, Nov 03, 2017 at 03:07:32PM +0100, Juergen Fitschen wrote: > Hello Ludovic, > > On Fri, Nov 03, 2017 at 09:46:02AM +0100, Ludovic Desroches wrote: > > > > > diff --git a/drivers/i2c/busses/i2c-at91.h > > > > > b/drivers/i2c/busses/i2c-at91.h > > > > > index bb502c1..4a4fa67 100644 > > > >

Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-11-03 Thread Juergen Fitschen
Hello Ludovic, On Fri, Nov 03, 2017 at 09:46:02AM +0100, Ludovic Desroches wrote: > > > > diff --git a/drivers/i2c/busses/i2c-at91.h > > > > b/drivers/i2c/busses/i2c-at91.h > > > > index bb502c1..4a4fa67 100644 > > > > --- a/drivers/i2c/busses/i2c-at91.h > > > > +++ b/drivers/i2c/busses/i2c-at91.

Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-11-03 Thread Ludovic Desroches
Hi Juergen, On Wed, Nov 01, 2017 at 12:16:36PM +0100, Juergen Fitschen wrote: > Hello Ludovic, > > Thank you very much for your feedback! > > On Tue, Oct 31, 2017 at 04:22:50PM +0100, Ludovic Desroches wrote: > > On Fri, Oct 27, 2017 at 05:12:17PM +0200, Juergen Fitschen wrote: > > > Some AT91 h

Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-11-02 Thread Ludovic Desroches
On Wed, Nov 01, 2017 at 12:16:36PM +0100, Juergen Fitschen wrote: > Hello Ludovic, > > Thank you very much for your feedback! > > On Tue, Oct 31, 2017 at 04:22:50PM +0100, Ludovic Desroches wrote: > > On Fri, Oct 27, 2017 at 05:12:17PM +0200, Juergen Fitschen wrote: > > > Some AT91 hardware has n

Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-11-01 Thread Juergen Fitschen
Hello Ludovic, Thank you very much for your feedback! On Tue, Oct 31, 2017 at 04:22:50PM +0100, Ludovic Desroches wrote: > On Fri, Oct 27, 2017 at 05:12:17PM +0200, Juergen Fitschen wrote: > > Some AT91 hardware has no slave mode included or only limited features > > (i.e. no fifos). > > > > I

Re: [PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-10-31 Thread Ludovic Desroches
On Fri, Oct 27, 2017 at 05:12:17PM +0200, Juergen Fitschen wrote: > Some AT91 hardware has no slave mode included or only limited features > (i.e. no fifos). > I am wondering if it won't be better to squash this patch into the previous one: Without it, it seems that we can set slave_detected for

[PATCH RFC 4/4] i2c: at91: take slave mode capabilities of hardware into account

2017-10-27 Thread Juergen Fitschen
Some AT91 hardware has no slave mode included or only limited features (i.e. no fifos). Signed-off-by: Juergen Fitschen --- drivers/i2c/busses/i2c-at91-core.c | 14 -- drivers/i2c/busses/i2c-at91.h | 5 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drive