Re: [PATCH RFC V8 3/4] perf,tools: per-event callgraph support

2015-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2015 at 03:45:27PM +, Liang, Kan escreveu: > > hum, calling parse_callchain_record_opt from evsel hurts the python code: > > > > 17: Try 'import perf' in python, checking link problems : > > --- start --- > > test child forked, pid 25751 > > Traceback (most recent call las

RE: [PATCH RFC V8 3/4] perf,tools: per-event callgraph support

2015-08-05 Thread Liang, Kan
> > + /* User explicitly set per-event callgraph, clear the old setting and > reset. */ > > + if ((callgraph_buf != NULL) || (dump_size > 0)) { > > + > > + /* parse callgraph parameters */ > > + if (callgraph_buf != NULL) { > > + if (!strcmp(callgraph_buf

Re: [PATCH RFC V8 3/4] perf,tools: per-event callgraph support

2015-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2015 at 04:30:21AM -0400, Kan Liang wrote: > From: Kan Liang > > When multiple events are sampled it may not be needed to collect > callgraphs for all of them. The sample sites are usually nearby, and > it's enough to collect the callgraphs on a reference event (such as > precise

Re: [PATCH RFC V8 3/4] perf,tools: per-event callgraph support

2015-08-05 Thread Jiri Olsa
On Tue, Aug 04, 2015 at 04:30:21AM -0400, Kan Liang wrote: SNIP > + > + /* User explicitly set per-event callgraph, clear the old setting and > reset. */ > + if ((callgraph_buf != NULL) || (dump_size > 0)) { > + > + /* parse callgraph parameters */ > + if (callgra

[PATCH RFC V8 3/4] perf,tools: per-event callgraph support

2015-08-04 Thread Kan Liang
From: Kan Liang When multiple events are sampled it may not be needed to collect callgraphs for all of them. The sample sites are usually nearby, and it's enough to collect the callgraphs on a reference event (such as precise cycles or precise instructions). This patchkit adds the ability to turn