Re: [PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-11-25 Thread Alexander Gordeev
On Wed, Nov 20, 2013 at 11:18:08AM -0500, Tejun Heo wrote: > > +If this function returns a negative number, it indicates the device is > > +not capable of sending MSIs. > > Wouldn't "errno" better describe the error return rather than > "negative number"? Term "negative number" is used

Re: [PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-11-25 Thread Alexander Gordeev
On Wed, Nov 20, 2013 at 11:18:08AM -0500, Tejun Heo wrote: +If this function returns a negative number, it indicates the device is +not capable of sending MSIs. Wouldn't errno better describe the error return rather than negative number? Term negative number is used throughout the whole

Re: [PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-11-20 Thread Tejun Heo
Hello, On Fri, Oct 18, 2013 at 07:12:09PM +0200, Alexander Gordeev wrote: > +If this function returns a negative number, it indicates the device is > +not capable of sending MSIs. Wouldn't "errno" better describe the error return rather than "negative number"? > @@ -795,6 +795,21 @@ static int

Re: [PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-11-20 Thread Tejun Heo
Hello, On Fri, Oct 18, 2013 at 07:12:09PM +0200, Alexander Gordeev wrote: +If this function returns a negative number, it indicates the device is +not capable of sending MSIs. Wouldn't errno better describe the error return rather than negative number? @@ -795,6 +795,21 @@ static int

[PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-19 Thread Alexander Gordeev
Device drivers can use this interface to obtain maximum number of MSI interrupts the device supports and use that number i.e. in a following call to pci_enable_msi_block() interface. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 15 +++ drivers/pci/msi.c

[PATCH RFC v2 09/29] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-19 Thread Alexander Gordeev
Device drivers can use this interface to obtain maximum number of MSI interrupts the device supports and use that number i.e. in a following call to pci_enable_msi_block() interface. Signed-off-by: Alexander Gordeev agord...@redhat.com --- Documentation/PCI/MSI-HOWTO.txt | 15 +++