Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-06-05 Thread Tadeusz Struk
On 06/05/2015 01:50 AM, Paul Bolle wrote: > This builds two modules if PUBLIC_KEY_ALGO_RSA = 'm': rsa.ko and > rsa_pkcs1_v1_5.ko. Is that what you want? No, this not what I wanted. > > public_key.c uses this, so it can end up in public_key.ko. But it's not > exported. So a _quick and dirty_ buil

Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-06-05 Thread Paul Bolle
A few remarks, perhaps not of the kind you'd like for an RFC, that I hope are still relevant after Herbert's comment. On Wed, 2015-06-03 at 15:44 -0700, Tadeusz Struk wrote: > --- a/crypto/asymmetric_keys/Makefile > +++ b/crypto/asymmetric_keys/Makefile > @@ -8,6 +8,7 @@ asymmetric_keys-y := asymm

Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-06-04 Thread Tadeusz Struk
On 06/03/2015 11:53 PM, Herbert Xu wrote: > I'd like to see this split into multiple patches. First of all > the new crypto_akcipher implementation should coexist with the > existing code. That way the exiting users can be converted over > one-by-one. > > Also you should implement the crypto_akc

Re: [PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-06-03 Thread Herbert Xu
On Wed, Jun 03, 2015 at 03:44:14PM -0700, Tadeusz Struk wrote: > Change the existing rsa and public key code to integrate it > with the new Public Key Encryption API. > > Signed-off-by: Tadeusz Struk I'd like to see this split into multiple patches. First of all the new crypto_akcipher implemen

[PATCH RFC v3 2/3] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-06-03 Thread Tadeusz Struk
Change the existing rsa and public key code to integrate it with the new Public Key Encryption API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|1 crypto/asymmetric_keys/Makefile |1 crypto/asymmetric_keys/pkcs7_parser.c |2 crypto/asy