Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-05 Thread Jason Wang
On 2016年06月03日 21:04, Michael S. Tsirkin wrote: On Fri, Jun 03, 2016 at 02:58:39PM +0200, Jesper Dangaard Brouer wrote: > >On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > > >A simple array based FIFO of pointers. Intended for net stack so uses > >skbs for

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-05 Thread Jason Wang
On 2016年06月03日 21:04, Michael S. Tsirkin wrote: On Fri, Jun 03, 2016 at 02:58:39PM +0200, Jesper Dangaard Brouer wrote: > >On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > > >A simple array based FIFO of pointers. Intended for net stack so uses > >skbs for type safety.

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
Could not compile this new version of skb_array.h, it complains about implicit declaration of function 'skb_vlan_tag_present' and 'VLAN_HLEN' being undeclared. Fix this by including linux/if_vlan.h, but is that correct? On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin"

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
Could not compile this new version of skb_array.h, it complains about implicit declaration of function 'skb_vlan_tag_present' and 'VLAN_HLEN' being undeclared. Fix this by including linux/if_vlan.h, but is that correct? On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > A simple

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Michael S. Tsirkin
On Fri, Jun 03, 2016 at 02:58:39PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" > wrote: > > > A simple array based FIFO of pointers. Intended for net stack so uses > > skbs for type safety. Implemented as a set of wrappers

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Michael S. Tsirkin
On Fri, Jun 03, 2016 at 02:58:39PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" > wrote: > > > A simple array based FIFO of pointers. Intended for net stack so uses > > skbs for type safety. Implemented as a set of wrappers around ptr_array.

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > A simple array based FIFO of pointers. Intended for net stack so uses > skbs for type safety. Implemented as a set of wrappers around ptr_array.

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > A simple array based FIFO of pointers. Intended for net stack so uses > skbs for type safety. Implemented as a set of wrappers around ptr_array. ^ It is

[PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-02 Thread Michael S. Tsirkin
A simple array based FIFO of pointers. Intended for net stack so uses skbs for type safety. Implemented as a set of wrappers around ptr_array. Signed-off-by: Michael S. Tsirkin --- include/linux/skb_array.h | 143 ++ 1 file changed,

[PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-02 Thread Michael S. Tsirkin
A simple array based FIFO of pointers. Intended for net stack so uses skbs for type safety. Implemented as a set of wrappers around ptr_array. Signed-off-by: Michael S. Tsirkin --- include/linux/skb_array.h | 143 ++ 1 file changed, 143 insertions(+)