Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-13 Thread Patrice CHOTARD
On 03/13/2013 02:59 PM, Linus Walleij wrote: > On Tue, Mar 5, 2013 at 7:58 AM, Axel Lin wrote: > >> It's pointless to check "af.alt_bit1 == UNUSED" twice. >> This looks like a copy-paste bug, I think what we want is to check if *both* >> af.alt_bit1 and af.alt_bit2 are UNUSED. >> >>

Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-13 Thread Linus Walleij
On Tue, Mar 5, 2013 at 7:58 AM, Axel Lin wrote: > It's pointless to check "af.alt_bit1 == UNUSED" twice. > This looks like a copy-paste bug, I think what we want is to check if *both* > af.alt_bit1 and af.alt_bit2 are UNUSED. > > Signed-off-by: Axel Lin Tentatively applied to fixes, waiting

Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-13 Thread Linus Walleij
On Tue, Mar 5, 2013 at 7:58 AM, Axel Lin axel@ingics.com wrote: It's pointless to check af.alt_bit1 == UNUSED twice. This looks like a copy-paste bug, I think what we want is to check if *both* af.alt_bit1 and af.alt_bit2 are UNUSED. Signed-off-by: Axel Lin axel@ingics.com

Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-13 Thread Patrice CHOTARD
On 03/13/2013 02:59 PM, Linus Walleij wrote: On Tue, Mar 5, 2013 at 7:58 AM, Axel Lin axel@ingics.com wrote: It's pointless to check af.alt_bit1 == UNUSED twice. This looks like a copy-paste bug, I think what we want is to check if *both* af.alt_bit1 and af.alt_bit2 are UNUSED.

[PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-04 Thread Axel Lin
It's pointless to check "af.alt_bit1 == UNUSED" twice. This looks like a copy-paste bug, I think what we want is to check if *both* af.alt_bit1 and af.alt_bit2 are UNUSED. Signed-off-by: Axel Lin --- Hi, I don't have the datasheet and hw. I'd appreciate if someone can review and test this patch.

[PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register

2013-03-04 Thread Axel Lin
It's pointless to check af.alt_bit1 == UNUSED twice. This looks like a copy-paste bug, I think what we want is to check if *both* af.alt_bit1 and af.alt_bit2 are UNUSED. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have the datasheet and hw. I'd appreciate if someone can review and