RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
el.org; bige...@linutronix.de; Patrice CHOTARD <patrice.chot...@st.com>; Greg Kroah-Hartman <gre...@linuxfoundation.org>; Jiri Slaby <jsl...@suse.com> Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware On Wed, 22 Mar 2017 08:43:50 + Lionel DEBIEVE <lion

RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
Kroah-Hartman ; Jiri Slaby Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware On Wed, 22 Mar 2017 08:43:50 + Lionel DEBIEVE wrote: > Just to agree with Thomas. > > Do you want me to resend the patch without RT tag? > Yes please. And hopefully it will

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 08:43:50 + Lionel DEBIEVE wrote: > Just to agree with Thomas. > > Do you want me to resend the patch without RT tag? > Yes please. And hopefully it will be picked up in mainline. -- Steve

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 08:43:50 + Lionel DEBIEVE wrote: > Just to agree with Thomas. > > Do you want me to resend the patch without RT tag? > Yes please. And hopefully it will be picked up in mainline. -- Steve

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: /* *

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: /* * Disable interrupts

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Steven Rostedt
On Tue, 21 Mar 2017 19:51:47 +0100 (CET) Thomas Gleixner wrote: > On Tue, 21 Mar 2017, Steven Rostedt wrote: > > > /* > > >* Disable interrupts so we don't get the IRQ line > > > bouncing > > > > I'm nervous about the above comment, which in full is: > > > > /*

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Steven Rostedt
On Tue, 21 Mar 2017 19:51:47 +0100 (CET) Thomas Gleixner wrote: > On Tue, 21 Mar 2017, Steven Rostedt wrote: > > > /* > > >* Disable interrupts so we don't get the IRQ line > > > bouncing > > > > I'm nervous about the above comment, which in full is: > > > > /* > > * Disable

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Thomas Gleixner
On Tue, 21 Mar 2017, Steven Rostedt wrote: > > /* > > * Disable interrupts so we don't get the IRQ line bouncing > > I'm nervous about the above comment, which in full is: > > /* >* Disable interrupts so we don't get the IRQ line bouncing >* up and down while

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Thomas Gleixner
On Tue, 21 Mar 2017, Steven Rostedt wrote: > > /* > > * Disable interrupts so we don't get the IRQ line bouncing > > I'm nervous about the above comment, which in full is: > > /* >* Disable interrupts so we don't get the IRQ line bouncing >* up and down while

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Steven Rostedt
On Tue, 21 Mar 2017 17:05:40 +0100 wrote: > From: Lionel Debieve > > The lock is a sleeping lock and local_irq_save() is not the > standard implementation now. Working for both -RT and non > RT. If this is for both RT and non RT then the patch

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread Steven Rostedt
On Tue, 21 Mar 2017 17:05:40 +0100 wrote: > From: Lionel Debieve > > The lock is a sleeping lock and local_irq_save() is not the > standard implementation now. Working for both -RT and non > RT. If this is for both RT and non RT then the patch subject should just be [PATCH] and not [PATCH RT]

[PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread lionel.debieve
From: Lionel Debieve The lock is a sleeping lock and local_irq_save() is not the standard implementation now. Working for both -RT and non RT. Signed-off-by: Lionel Debieve --- drivers/tty/serial/st-asc.c | 8 +++- 1 file changed, 3

[PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-21 Thread lionel.debieve
From: Lionel Debieve The lock is a sleeping lock and local_irq_save() is not the standard implementation now. Working for both -RT and non RT. Signed-off-by: Lionel Debieve --- drivers/tty/serial/st-asc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git