Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Tom Zanussi
On Tue, 2020-06-09 at 23:03 +0300, Ramon Fried wrote: > On Tue, Jun 9, 2020 at 8:20 PM Tom Zanussi > wrote: > > > > Hi Ramon, > > > > On Tue, 2020-06-09 at 20:14 +0300, Ramon Fried wrote: > > > > > > On June 9, 2020 8:10:43 PM GMT+03:00, Sebastian Andrzej Siewior < > > > bige...@linutronix.de>

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Ramon Fried
On Tue, Jun 9, 2020 at 8:20 PM Tom Zanussi wrote: > > Hi Ramon, > > On Tue, 2020-06-09 at 20:14 +0300, Ramon Fried wrote: > > > > On June 9, 2020 8:10:43 PM GMT+03:00, Sebastian Andrzej Siewior < > > bige...@linutronix.de> wrote: > > > On 2020-06-09 20:07:06 [+0300], Ramon Fried wrote: > > > >

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Tom Zanussi
Hi Ramon, On Tue, 2020-06-09 at 20:14 +0300, Ramon Fried wrote: > > On June 9, 2020 8:10:43 PM GMT+03:00, Sebastian Andrzej Siewior < > bige...@linutronix.de> wrote: > > On 2020-06-09 20:07:06 [+0300], Ramon Fried wrote: > > > Indeed > > > I'm truly sorry, I thought our crash kernel is

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Ramon Fried
On June 9, 2020 8:10:43 PM GMT+03:00, Sebastian Andrzej Siewior wrote: >On 2020-06-09 20:07:06 [+0300], Ramon Fried wrote: >> Indeed >> I'm truly sorry, I thought our crash kernel is configured as RT as >well. >> so, as I understand, if I build the RT kernel without preempt enabled >I can

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Sebastian Andrzej Siewior
On 2020-06-09 20:07:06 [+0300], Ramon Fried wrote: > Indeed > I'm truly sorry, I thought our crash kernel is configured as RT as well. > so, as I understand, if I build the RT kernel without preempt enabled I can > hit this bug? Don't worry, I should have been better with the details in the

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Ramon Fried
On June 9, 2020 7:42:13 PM GMT+03:00, Sebastian Andrzej Siewior wrote: >On 2020-06-09 19:40:03 [+0300], Ramon Fried wrote: >> Correction. normal kernel is running with RT enabled, crash kernel >without. > >no RT and no SMP in your crash kernel? So this information in your >first >email would

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Tom Zanussi
Hi Sebastian, On Tue, 2020-06-09 at 18:34 +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-09 11:17:53 [-0500], Tom Zanussi wrote: > > Hi Sebastian, > > Hi Tom, > > > I did find a problem with the patch when configured as !SMP since > > in > > that case the RUN flag is never set (will send

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Sebastian Andrzej Siewior
On 2020-06-09 19:40:03 [+0300], Ramon Fried wrote: > Correction. normal kernel is running with RT enabled, crash kernel without. no RT and no SMP in your crash kernel? So this information in your first email would have saved me some timeā€¦ Sebastian

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Ramon Fried
On June 9, 2020 7:37:31 PM GMT+03:00, Ramon Fried wrote: > > >On June 9, 2020 7:34:46 PM GMT+03:00, Sebastian Andrzej Siewior > wrote: >>On 2020-06-09 11:17:53 [-0500], Tom Zanussi wrote: >>> Hi Sebastian, >>Hi Tom, >> >>> I did find a problem with the patch when configured as !SMP since in

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Ramon Fried
On June 9, 2020 7:34:46 PM GMT+03:00, Sebastian Andrzej Siewior wrote: >On 2020-06-09 11:17:53 [-0500], Tom Zanussi wrote: >> Hi Sebastian, >Hi Tom, > >> I did find a problem with the patch when configured as !SMP since in >> that case the RUN flag is never set (will send a patch for that >>

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Sebastian Andrzej Siewior
On 2020-06-09 11:17:53 [-0500], Tom Zanussi wrote: > Hi Sebastian, Hi Tom, > I did find a problem with the patch when configured as !SMP since in > that case the RUN flag is never set (will send a patch for that > shortly), but that wouldn't be the case here. How? | #if defined(CONFIG_SMP) ||

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Tom Zanussi
Hi Sebastian, On Tue, 2020-06-09 at 17:47 +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-04 15:51:14 [-0500], Tom Zanussi wrote: > > > > > > Hi, This patch introduced a regression in our kernel > > > (v4.19.124-rt53-rebase), It occurs when we're jumping to crush > > > kernel > > > using

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-09 Thread Sebastian Andrzej Siewior
On 2020-06-04 15:51:14 [-0500], Tom Zanussi wrote: > > > > Hi, This patch introduced a regression in our kernel > > (v4.19.124-rt53-rebase), It occurs when we're jumping to crush kernel > > using kexec, in the initialization of the emmc driver. > > I'm still debugging the root cause, but I

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-04 Thread Tom Zanussi
Hi Ramon, On Thu, 2020-06-04 at 19:04 +0300, Ramon Fried wrote: > On Thu, Apr 23, 2020 at 11:55 PM wrote: > > > > From: Zhang Xiao > > > > v4.19.115-rt49-rc1 stable review patch. > > If anyone has any objections, please let me know. > > > > --- > > > > > > The kernel bugzilla has

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-04 Thread Ramon Fried
On Thu, Apr 23, 2020 at 11:55 PM wrote: > > From: Zhang Xiao > > v4.19.115-rt49-rc1 stable review patch. > If anyone has any objections, please let me know. > > --- > > > The kernel bugzilla has the following race condition reported: > > CPU0CPU1CPU2 >