Re: [PATCH RT 3/3] fix get_monotonic_cycles for latency tracer

2007-08-24 Thread Steven Rostedt
-- On Fri, 24 Aug 2007, john stultz wrote: > > > > - /* calculate the delta since the last update_wall_time: */ > > - cycle_delta = (cycle_now - clock->cycle_last) & clock->mask; > > + } while (cycle_raw != clock->cycle_raw || > > +cycle_last != clock->cycle_last); > > So if I'

Re: [PATCH RT 3/3] fix get_monotonic_cycles for latency tracer

2007-08-24 Thread john stultz
On Fri, 2007-08-24 at 13:57 -0400, Steven Rostedt wrote: > The latency tracer on SMP was given crazy results. It was found that the > get_monotonic_cycles that it uses was not returning a monotonic counter. > The cause of this was that clock->cycles_raw and clock->cycles_last can > be updated on an

[PATCH RT 3/3] fix get_monotonic_cycles for latency tracer

2007-08-24 Thread Steven Rostedt
The latency tracer on SMP was given crazy results. It was found that the get_monotonic_cycles that it uses was not returning a monotonic counter. The cause of this was that clock->cycles_raw and clock->cycles_last can be updated on another CPU and make the cycles_now variable out-of-date. So the de