Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-11 Thread Linus Walleij
On Tue, Sep 12, 2017 at 2:32 AM, wrote: > From: Fenglin Wu > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > configured. Update is_enabled flag in config_set() so that it can > reflect GPIO status correctly. Also modify EN_CTL register based on > is_enabled flag in con

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-10 Thread Bjorn Andersson
On Mon 09 Oct 17:17 PDT 2017, Fenglin Wu wrote: > On 10/9/2017 1:56 PM, Bjorn Andersson wrote: > > On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: > > > > > On 10/6/2017 12:27 AM, Bjorn Andersson wrote: [..] > > > > But I spotted another issue while reviewing this; currently the initial > > > > s

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-09 Thread Fenglin Wu
On 10/9/2017 1:56 PM, Bjorn Andersson wrote: On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is con

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-08 Thread Bjorn Andersson
On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: > On 10/6/2017 12:27 AM, Bjorn Andersson wrote: > > On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: > > > > > From: Fenglin Wu > > > > > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > > > configured. Update

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-08 Thread Fenglin Wu
On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is configured. Update is_enabled flag in config_set() so that it can reflect GPIO status correctly. Al

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-05 Thread Bjorn Andersson
On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: > From: Fenglin Wu > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > configured. Update is_enabled flag in config_set() so that it can > reflect GPIO status correctly. Also modify EN_CTL register based on > is

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-09-19 Thread Linus Walleij
On Tue, Sep 12, 2017 at 2:32 AM, wrote: > From: Fenglin Wu > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > configured. Update is_enabled flag in config_set() so that it can > reflect GPIO status correctly. Also modify EN_CTL register based on > is_enabled flag in con

[PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-09-11 Thread fenglinw
From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is configured. Update is_enabled flag in config_set() so that it can reflect GPIO status correctly. Also modify EN_CTL register based on is_enabled flag in config_set() to configure the GPIO properly. Signed-off-