Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-21 Thread Bjorn Andersson
On Wed 20 May 04:16 PDT 2020, Veerabhadrarao Badiganti wrote: > > Thanks Bjorn for the review. For major comments I'm responding. > Other comments, i will take care of them in my next patch-set. > > On 5/19/2020 1:27 AM, Bjorn Andersson wrote: > > On Fri 15 May 04:18 PDT 2020, Veerabhadrarao

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-20 Thread Veerabhadrarao Badiganti
Thanks Bjorn for the review. For major comments I'm responding. Other comments, i will take care of them in my next patch-set. On 5/19/2020 1:27 AM, Bjorn Andersson wrote: On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: From: Vijay Viswanath On qcom SD host controllers

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:57 PDT 2020, Bjorn Andersson wrote: > On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c [..] > > +static int sdhci_msm_register_vreg(struct sdhci_msm_host *msm_host) > > +{ > > + int ret =

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: > From: Vijay Viswanath > > On qcom SD host controllers voltage switching be done after the HW > is ready for it. The HW informs its readiness through power irq. > The voltage switching should happen only then. > > Use the internal

[PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-15 Thread Veerabhadrarao Badiganti
From: Vijay Viswanath On qcom SD host controllers voltage switching be done after the HW is ready for it. The HW informs its readiness through power irq. The voltage switching should happen only then. Use the internal voltage switching and then control the voltage switching using power irq.