Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread kgunda
On 2017-07-06 12:23, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread kgunda
On 2017-07-06 12:23, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can cause a forbidden warning

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread Stephen Boyd
On 07/03, Kiran Gunda wrote: > From: Fenglin Wu > > The opc parameter in pmic_arb_write_cmd() function is defined with type > u8 and it's always greater than or equal to 0. Checking that it's not > less than 0 is redundant and it can cause a forbidden warning during >

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread Stephen Boyd
On 07/03, Kiran Gunda wrote: > From: Fenglin Wu > > The opc parameter in pmic_arb_write_cmd() function is defined with type > u8 and it's always greater than or equal to 0. Checking that it's not > less than 0 is redundant and it can cause a forbidden warning during > compilation. Remove the

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread Stephen Boyd
On 07/03, Kiran Gunda wrote: > From: Fenglin Wu > > The opc parameter in pmic_arb_write_cmd() function is defined with type > u8 and it's always greater than or equal to 0. Checking that it's not > less than 0 is redundant and it can cause a forbidden warning during >

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-06 Thread Stephen Boyd
On 07/03, Kiran Gunda wrote: > From: Fenglin Wu > > The opc parameter in pmic_arb_write_cmd() function is defined with type > u8 and it's always greater than or equal to 0. Checking that it's not > less than 0 is redundant and it can cause a forbidden warning during > compilation. Remove the

[PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-03 Thread Kiran Gunda
From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can cause a forbidden warning during compilation. Remove the check.

[PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

2017-07-03 Thread Kiran Gunda
From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can cause a forbidden warning during compilation. Remove the check. Signed-off-by: Fenglin Wu ---