On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
There were some missing explanations in my previous e-mails for some of
your comments. Please find them below.
During the da9062_wdt_probe() there were several ignored error paths and
a missing cleanup . I intend to rectify this with the
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
There were some missing explanations in my previous e-mails for some of
your comments. Please find them below.
During the da9062_wdt_probe() there were several ignored error paths and
a missing cleanup . I intend to rectify this with the
On 07 May 2015 18:58 Guenter Roeck wrote:
Hi Guenter,
> > +static void da9062_apply_window_protection(struct da9062_watchdog *wdt)
> > +{
> > + unsigned long delay = msecs_to_jiffies(DA9062_RESET_PROTECTION_MS);
> > + unsigned long timeout = wdt->j_time_stamp + delay;
> > +
On Thu, May 07, 2015 at 05:45:13PM +, Opensource [Steve Twiss] wrote:
> On 06 May 2015 21:07 Guenter Roeck wrote:
>
> > > > > The DA9062 watchdog ping (register CONTROL_F) is "windowed" for
> > > > > protection
> > > > > against spurious writes -- i.e. the ping function cannot be called
> >
On 06 May 2015 21:07 Guenter Roeck wrote:
> > > > The DA9062 watchdog ping (register CONTROL_F) is "windowed" for
> > > > protection
> > > > against spurious writes -- i.e. the ping function cannot be called
> > > > within a 250ms
> > > > time limit or the PMIC will reset. This windowing
On Thu, May 07, 2015 at 05:45:13PM +, Opensource [Steve Twiss] wrote:
On 06 May 2015 21:07 Guenter Roeck wrote:
The DA9062 watchdog ping (register CONTROL_F) is windowed for
protection
against spurious writes -- i.e. the ping function cannot be called
within a 250ms
On 07 May 2015 18:58 Guenter Roeck wrote:
Hi Guenter,
+static void da9062_apply_window_protection(struct da9062_watchdog *wdt)
+{
+ unsigned long delay = msecs_to_jiffies(DA9062_RESET_PROTECTION_MS);
+ unsigned long timeout = wdt-j_time_stamp + delay;
+ unsigned long
On 06 May 2015 21:07 Guenter Roeck wrote:
The DA9062 watchdog ping (register CONTROL_F) is windowed for
protection
against spurious writes -- i.e. the ping function cannot be called
within a 250ms
time limit or the PMIC will reset. This windowing protection also
extends
On Wed, May 06, 2015 at 04:30:50PM +, Opensource [Steve Twiss] wrote:
>
> On 06 May 2015 17:02 Guenter Roeck wrote:
>
> > On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
> > > On 18 April 2015 16:53 Guenter Roeck wrote:
> > >
> > > Hi Guenter,
> > >
> > > Thanks for
On 06 May 2015 17:02 Guenter Roeck wrote:
> On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
> > On 18 April 2015 16:53 Guenter Roeck wrote:
> >
> > Hi Guenter,
> >
> > Thanks for your comments.
> >
> > > On 04/17/2015 07:23 AM, S Twiss wrote:
> > > > From: S Twiss
> >
On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
> On 18 April 2015 16:53 Guenter Roeck wrote:
>
> Hi Guenter,
>
> Thanks for your comments.
>
> > On 04/17/2015 07:23 AM, S Twiss wrote:
> > > From: S Twiss
> > >
> > > Add watchdog driver support for DA9062
> > >
> > >
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
Thanks for your comments.
> On 04/17/2015 07:23 AM, S Twiss wrote:
> > From: S Twiss
> >
> > Add watchdog driver support for DA9062
> >
> > Signed-off-by: Steve Twiss
> >
> Hi Steve,
>
> Key question here is if the da9062 is really so
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
Thanks for your comments.
On 04/17/2015 07:23 AM, S Twiss wrote:
From: S Twiss stwiss.opensou...@diasemi.com
Add watchdog driver support for DA9062
Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com
Hi Steve,
Key
On Wed, May 06, 2015 at 04:30:50PM +, Opensource [Steve Twiss] wrote:
On 06 May 2015 17:02 Guenter Roeck wrote:
On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
Thanks for your comments.
On 06 May 2015 17:02 Guenter Roeck wrote:
On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
Thanks for your comments.
On 04/17/2015 07:23 AM, S Twiss wrote:
From: S Twiss
On Wed, May 06, 2015 at 02:54:37PM +, Opensource [Steve Twiss] wrote:
On 18 April 2015 16:53 Guenter Roeck wrote:
Hi Guenter,
Thanks for your comments.
On 04/17/2015 07:23 AM, S Twiss wrote:
From: S Twiss stwiss.opensou...@diasemi.com
Add watchdog driver support for DA9062
On 04/17/2015 07:23 AM, S Twiss wrote:
From: S Twiss
Add watchdog driver support for DA9062
Signed-off-by: Steve Twiss
Hi Steve,
Key question here is if the da9062 is really so much different to the da9062
that you can not use the same driver. I am especially concerned about
the added
On 04/17/2015 07:23 AM, S Twiss wrote:
From: S Twiss stwiss.opensou...@diasemi.com
Add watchdog driver support for DA9062
Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com
Hi Steve,
Key question here is if the da9062 is really so much different to the da9062
that you can not use the
From: S Twiss
Add watchdog driver support for DA9062
Signed-off-by: Steve Twiss
---
This patch applies against linux-next and v4.0
drivers/watchdog/Kconfig | 9 ++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/da9062_wdt.c | 249
From: S Twiss stwiss.opensou...@diasemi.com
Add watchdog driver support for DA9062
Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com
---
This patch applies against linux-next and v4.0
drivers/watchdog/Kconfig | 9 ++
drivers/watchdog/Makefile | 1 +
20 matches
Mail list logo
