Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-11-29 Thread Viresh Kumar
On 13-11-15, 13:53, Viresh Kumar wrote: > On 29-10-15, 07:57, Viresh Kumar wrote: > > On 13-10-15, 13:57, Viresh Kumar wrote: > > > IS_ERR_VALUE() already contains it and so we need to add this only to > > > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > > > this compiler

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-11-29 Thread Viresh Kumar
On 13-11-15, 13:53, Viresh Kumar wrote: > On 29-10-15, 07:57, Viresh Kumar wrote: > > On 13-10-15, 13:57, Viresh Kumar wrote: > > > IS_ERR_VALUE() already contains it and so we need to add this only to > > > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > > > this compiler

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-11-13 Thread Viresh Kumar
On 29-10-15, 07:57, Viresh Kumar wrote: > On 13-10-15, 13:57, Viresh Kumar wrote: > > IS_ERR_VALUE() already contains it and so we need to add this only to > > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > > this compiler flag. > > > > Signed-off-by: Viresh Kumar > >

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-11-13 Thread Viresh Kumar
On 29-10-15, 07:57, Viresh Kumar wrote: > On 13-10-15, 13:57, Viresh Kumar wrote: > > IS_ERR_VALUE() already contains it and so we need to add this only to > > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > > this compiler flag. > > > > Signed-off-by: Viresh Kumar

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-10-28 Thread Viresh Kumar
On 13-10-15, 13:57, Viresh Kumar wrote: > IS_ERR_VALUE() already contains it and so we need to add this only to > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > this compiler flag. > > Signed-off-by: Viresh Kumar > --- > @Jiri: You have applied all other patches, but

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-10-28 Thread Viresh Kumar
On 13-10-15, 13:57, Viresh Kumar wrote: > IS_ERR_VALUE() already contains it and so we need to add this only to > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > this compiler flag. > > Signed-off-by: Viresh Kumar > --- > @Jiri: You have applied

[PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-10-13 Thread Viresh Kumar
IS_ERR_VALUE() already contains it and so we need to add this only to the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add this compiler flag. Signed-off-by: Viresh Kumar --- @Jiri: You have applied all other patches, but this one. Can you please apply this one as well, as all

[PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-10-13 Thread Viresh Kumar
IS_ERR_VALUE() already contains it and so we need to add this only to the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add this compiler flag. Signed-off-by: Viresh Kumar --- @Jiri: You have applied all other patches, but this one. Can you please apply