Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Thu, Oct 05, 2017 at 01:42:09PM -0500, Bjorn Helgaas wrote: >On Thu, Oct 05, 2017 at 11:05:12PM +0800, Wei Yang wrote: >> On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: >> > [+cc Alex, Gavin, Wei] >> > >> > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Thu, Oct 05, 2017 at 01:42:09PM -0500, Bjorn Helgaas wrote: >On Thu, Oct 05, 2017 at 11:05:12PM +0800, Wei Yang wrote: >> On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: >> > [+cc Alex, Gavin, Wei] >> > >> > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: >> >>

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Thu, Oct 05, 2017 at 11:05:12PM +0800, Wei Yang wrote: > On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: > > [+cc Alex, Gavin, Wei] > > > > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: > >> CPU0 CPU1 > >>

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Thu, Oct 05, 2017 at 11:05:12PM +0800, Wei Yang wrote: > On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: > > [+cc Alex, Gavin, Wei] > > > > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: > >> CPU0 CPU1 > >>

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: > [+cc Alex, Gavin, Wei] > > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: >> CPU0 CPU1 >> -

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: > [+cc Alex, Gavin, Wei] > > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: >> CPU0 CPU1 >> - >> __driver_attach()

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

[+cc Alex, Gavin, Wei] On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: > CPU0 CPU1 > - > __driver_attach() > device_lock(>mutex) <--- device mutex lock here >

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

[+cc Alex, Gavin, Wei] On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: > CPU0 CPU1 > - > __driver_attach() > device_lock(>mutex) <--- device mutex lock here >

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Mon, Oct 02, 2017 at 05:14:09PM -0700, Govindarajulu Varadarajan wrote: > > I would avoid increasing the size of pci_dev. The list_head would be empty > after > we call aer_pci_walk_bus(). We already have pci_bus *subordinate to link all > the > 'device's. Making list_head available to others

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Mon, Oct 02, 2017 at 05:14:09PM -0700, Govindarajulu Varadarajan wrote: > > I would avoid increasing the size of pci_dev. The list_head would be empty > after > we call aer_pci_walk_bus(). We already have pci_bus *subordinate to link all > the > 'device's. Making list_head available to others

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Sat, 30 Sep 2017, Sinan Kaya wrote: On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: This patch does a pci_bus_walk and adds all the devices to a list. After unlocking (up_read) _bus_sem, we go through the list and call err_handler of the devices with devic_lock() held. This way, we

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Sat, 30 Sep 2017, Sinan Kaya wrote: On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: This patch does a pci_bus_walk and adds all the devices to a list. After unlocking (up_read) _bus_sem, we go through the list and call err_handler of the devices with devic_lock() held. This way, we

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Sun, 1 Oct 2017, Christoph Hellwig wrote: +struct aer_device_list { + struct device *dev; + struct hlist_node node; +}; + extern struct bus_type pcie_port_bus_type; void aer_isr(struct work_struct *work); void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On Sun, 1 Oct 2017, Christoph Hellwig wrote: +struct aer_device_list { + struct device *dev; + struct hlist_node node; +}; + extern struct bus_type pcie_port_bus_type; void aer_isr(struct work_struct *work); void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

Can you please start with an explanation of the problem in text and cut down the cycle of involved functions to those actually relevant? That'll make reviewing the patch a bit easier.. > 2 files changed, 48 insertions(+), 2 deletions(-) > diff --git a/drivers/pci/pcie/aer/aerdrv.h

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

Can you please start with an explanation of the problem in text and cut down the cycle of involved functions to those actually relevant? That'll make reviewing the patch a bit easier.. > 2 files changed, 48 insertions(+), 2 deletions(-) > diff --git a/drivers/pci/pcie/aer/aerdrv.h

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: > This patch does a pci_bus_walk and adds all the devices to a list. After > unlocking (up_read) _bus_sem, we go through the list and call > err_handler of the devices with devic_lock() held. This way, we dont try > to hold both locks at same

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: > This patch does a pci_bus_walk and adds all the devices to a list. After > unlocking (up_read) _bus_sem, we go through the list and call > err_handler of the devices with devic_lock() held. This way, we dont try > to hold both locks at same

[PATCH V2] PCI: AER: fix deadlock in do_recovery

CPU0CPU1 - __driver_attach() device_lock(>mutex) <--- device mutex lock here driver_probe_device() pci_enable_sriov() pci_iov_add_virtfn() pci_device_add()

[PATCH V2] PCI: AER: fix deadlock in do_recovery

CPU0CPU1 - __driver_attach() device_lock(>mutex) <--- device mutex lock here driver_probe_device() pci_enable_sriov() pci_iov_add_virtfn() pci_device_add()