Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-25 Thread Rafael J. Wysocki
On Tuesday, September 22, 2015 09:51:27 AM Stephen Boyd wrote: > On 09/22, Viresh Kumar wrote: > > of_property_count_u32_elems() will never return 0, but a -ve error value > > of a positive count. And so the current !count check is wrong. > > > > Also, a missing "opp-microvolt" property isn't a

Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-25 Thread Rafael J. Wysocki
On Tuesday, September 22, 2015 09:51:27 AM Stephen Boyd wrote: > On 09/22, Viresh Kumar wrote: > > of_property_count_u32_elems() will never return 0, but a -ve error value > > of a positive count. And so the current !count check is wrong. > > > > Also, a missing "opp-microvolt" property isn't a

Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-22 Thread Stephen Boyd
On 09/22, Viresh Kumar wrote: > of_property_count_u32_elems() will never return 0, but a -ve error value > of a positive count. And so the current !count check is wrong. > > Also, a missing "opp-microvolt" property isn't a problem and so we need > to do of_find_property() separately to confirm

[PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-22 Thread Viresh Kumar
of_property_count_u32_elems() will never return 0, but a -ve error value of a positive count. And so the current !count check is wrong. Also, a missing "opp-microvolt" property isn't a problem and so we need to do of_find_property() separately to confirm that. Fixes: 274659029c9d ("PM / OPP: Add

Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-22 Thread Stephen Boyd
On 09/22, Viresh Kumar wrote: > of_property_count_u32_elems() will never return 0, but a -ve error value > of a positive count. And so the current !count check is wrong. > > Also, a missing "opp-microvolt" property isn't a problem and so we need > to do of_find_property() separately to confirm

[PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

2015-09-22 Thread Viresh Kumar
of_property_count_u32_elems() will never return 0, but a -ve error value of a positive count. And so the current !count check is wrong. Also, a missing "opp-microvolt" property isn't a problem and so we need to do of_find_property() separately to confirm that. Fixes: 274659029c9d ("PM / OPP: Add