Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-04-01 Thread Dan Carpenter
On Tue, Mar 31, 2015 at 01:25:02PM -0600, Eddie Kovsky wrote: > On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote: > > On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: > > > Change function definition to static, move the function further up in > > > the file, and delete

Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-04-01 Thread Dan Carpenter
On Tue, Mar 31, 2015 at 01:25:02PM -0600, Eddie Kovsky wrote: On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote: On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: Change function definition to static, move the function further up in the file, and delete the

Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-31 Thread Eddie Kovsky
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote: > On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: > > Change function definition to static, move the function further up in > > the file, and delete the function prototype. > > > > This fixes the following warning

Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-31 Thread Dan Carpenter
On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: > Change function definition to static, move the function further up in > the file, and delete the function prototype. > > This fixes the following warning generated by sparse: > > drivers/staging/rtl8192u/r8192U_core.c:1970:6:

Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-31 Thread Dan Carpenter
On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: Change function definition to static, move the function further up in the file, and delete the function prototype. This fixes the following warning generated by sparse: drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning:

Re: [PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-31 Thread Eddie Kovsky
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote: On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote: Change function definition to static, move the function further up in the file, and delete the function prototype. This fixes the following warning generated by

[PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-30 Thread Eddie Kovsky
Change function definition to static, move the function further up in the file, and delete the function prototype. This fixes the following warning generated by sparse: drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol 'rtl8192_update_ratr_table' was not declared. Should it be

[PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-30 Thread Eddie Kovsky
Change function definition to static, move the function further up in the file, and delete the function prototype. This fixes the following warning generated by sparse: drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol 'rtl8192_update_ratr_table' was not declared. Should it be