Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-07-14 Thread Sergey Senozhatsky
On (07/14/15 16:03), Andrew Morton wrote: > > Sergey Senozhatsky has modified several destroy functions that can > > now be called with NULL values. > > > > - kmem_cache_destroy() > > - mempool_destroy() > > - dma_pool_destroy() > > > > Update checkpatch to warn when those functions are

Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-07-14 Thread Andrew Morton
On Tue, 09 Jun 2015 22:52:29 -0700 Joe Perches wrote: > Sergey Senozhatsky has modified several destroy functions that can > now be called with NULL values. > > - kmem_cache_destroy() > - mempool_destroy() > - dma_pool_destroy() > > Update checkpatch to warn when those functions are

Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-06-11 Thread Julia Lawall
On Thu, 11 Jun 2015, Sergey Senozhatsky wrote: > On (06/11/15 11:41), Julia Lawall wrote: > > On Tue, 9 Jun 2015, Joe Perches wrote: > > > > > Sergey Senozhatsky has modified several destroy functions that can > > > now be called with NULL values. > > > > > > - kmem_cache_destroy() > > > -

Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-06-11 Thread Sergey Senozhatsky
On (06/11/15 11:41), Julia Lawall wrote: > On Tue, 9 Jun 2015, Joe Perches wrote: > > > Sergey Senozhatsky has modified several destroy functions that can > > now be called with NULL values. > > > > - kmem_cache_destroy() > > - mempool_destroy() > > - dma_pool_destroy() > > I don't actually

Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-06-11 Thread Julia Lawall
On Tue, 9 Jun 2015, Joe Perches wrote: > Sergey Senozhatsky has modified several destroy functions that can > now be called with NULL values. > > - kmem_cache_destroy() > - mempool_destroy() > - dma_pool_destroy() I don't actually see any null test in the definition of dma_pool_destroy, in

Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-06-10 Thread Sergey Senozhatsky
On (06/09/15 22:52), Joe Perches wrote: > Sergey Senozhatsky has modified several destroy functions that can > now be called with NULL values. > > - kmem_cache_destroy() > - mempool_destroy() > - dma_pool_destroy() > > Update checkpatch to warn when those functions are preceded by an if. > >

[PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests

2015-06-09 Thread Joe Perches
Sergey Senozhatsky has modified several destroy functions that can now be called with NULL values. - kmem_cache_destroy() - mempool_destroy() - dma_pool_destroy() Update checkpatch to warn when those functions are preceded by an if. Update checkpatch to --fix all the calls too only when the