Re: [PATCH V2] livepatch: fix non-static warnings

2019-01-22 Thread Nicholas Mc Guire
On Tue, Jan 22, 2019 at 11:30:30AM -0500, Joe Lawrence wrote: > On 12/18/18 10:18 AM, Joe Lawrence wrote: > >On 12/18/2018 03:49 AM, Miroslav Benes wrote: > >>On Mon, 17 Dec 2018, Joe Lawrence wrote: > >> > >>>I'm just being picky about its documentation and how we should note its > >>>usage in

Re: [PATCH V2] livepatch: fix non-static warnings

2019-01-22 Thread Joe Lawrence
On 12/18/18 10:18 AM, Joe Lawrence wrote: On 12/18/2018 03:49 AM, Miroslav Benes wrote: On Mon, 17 Dec 2018, Joe Lawrence wrote: I'm just being picky about its documentation and how we should note its usage in the v3 patch. Think that s/__noclone/used/g of the v2 commit message would be

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-18 Thread Joe Lawrence
On 12/18/2018 03:49 AM, Miroslav Benes wrote: > On Mon, 17 Dec 2018, Joe Lawrence wrote: > >> I'm just being picky about its documentation and how we should note its >> usage in the v3 patch. Think that s/__noclone/used/g of the v2 commit >> message would be sufficient? > > We could rephrase

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-18 Thread Miroslav Benes
On Mon, 17 Dec 2018, Nicholas Mc Guire wrote: > On Mon, Dec 17, 2018 at 10:44:36AM -0500, Joe Lawrence wrote: > > On 12/17/2018 07:03 AM, Miroslav Benes wrote: > > > Hi, > > > > > > I'm sorry for being late to the party. > > > > > > On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > > > > > >>

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-18 Thread Miroslav Benes
On Mon, 17 Dec 2018, Joe Lawrence wrote: > On 12/17/2018 07:03 AM, Miroslav Benes wrote: > > Hi, > > > > I'm sorry for being late to the party. > > > > On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > > > >> Sparse reported warnings about non-static symbols. For the variables > >> a simple

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-17 Thread Nicholas Mc Guire
On Mon, Dec 17, 2018 at 10:44:36AM -0500, Joe Lawrence wrote: > On 12/17/2018 07:03 AM, Miroslav Benes wrote: > > Hi, > > > > I'm sorry for being late to the party. > > > > On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > > > >> Sparse reported warnings about non-static symbols. For the

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-17 Thread Joe Lawrence
On 12/17/2018 07:03 AM, Miroslav Benes wrote: > Hi, > > I'm sorry for being late to the party. > > On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > >> Sparse reported warnings about non-static symbols. For the variables >> a simple static attribute is fine - for those symbols referenced by >>

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-17 Thread Miroslav Benes
Hi, I'm sorry for being late to the party. On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > Sparse reported warnings about non-static symbols. For the variables > a simple static attribute is fine - for those symbols referenced by > livepatch via klp_func the symbol-names must be unmodified in

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-17 Thread Petr Mladek
On Sun 2018-12-16 14:07:37, Nicholas Mc Guire wrote: > Sparse reported warnings about non-static symbols. For the variables > a simple static attribute is fine - for those symbols referenced by > livepatch via klp_func the symbol-names must be unmodified in the > symbol table - to resolve this the

[PATCH V2] livepatch: fix non-static warnings

2018-12-16 Thread Nicholas Mc Guire
Sparse reported warnings about non-static symbols. For the variables a simple static attribute is fine - for those symbols referenced by livepatch via klp_func the symbol-names must be unmodified in the symbol table - to resolve this the __noclone attribute is used for the shared statically