Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]

2016-02-07 Thread Pan Xinhui
hi, Greg thanks for your reply. On 2016/2/7 15:29, Greg Kroah-Hartman wrote: On Tue, Jan 05, 2016 at 03:42:52PM +0800, Pan Xinhui wrote: From: Pan Xinhui There is one filed gsm->num to store mux's index of gsm_mux[]. So use gsm->num to remove itself from gsm_mux[] instead of the for-lo

Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]

2016-02-06 Thread Greg Kroah-Hartman
On Tue, Jan 05, 2016 at 03:42:52PM +0800, Pan Xinhui wrote: > From: Pan Xinhui > > There is one filed gsm->num to store mux's index of gsm_mux[]. So use > gsm->num to remove itself from gsm_mux[] instead of the for-loop > traverse in gsm_cleanup_mux(). > > Signed-off-by: Pan Xinhui > Reviewed-b

Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]

2016-01-05 Thread One Thousand Gnomes
On Tue, 05 Jan 2016 15:42:52 +0800 Pan Xinhui wrote: > From: Pan Xinhui > > There is one filed gsm->num to store mux's index of gsm_mux[]. So use > gsm->num to remove itself from gsm_mux[] instead of the for-loop > traverse in gsm_cleanup_mux(). > > Signed-off-by: Pan Xinhui Reviewed-by: Ala

[PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]

2016-01-04 Thread Pan Xinhui
From: Pan Xinhui There is one filed gsm->num to store mux's index of gsm_mux[]. So use gsm->num to remove itself from gsm_mux[] instead of the for-loop traverse in gsm_cleanup_mux(). Signed-off-by: Pan Xinhui --- change from V1: lock is also held for the if() --- drivers/tty/n_gsm.c |