Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Kevin Cernekee
On Thu, Oct 30, 2014 at 3:48 AM, Arnd Bergmann wrote: > On Thursday 30 October 2014 11:43:00 Thomas Gleixner wrote: >> On Thu, 30 Oct 2014, Arnd Bergmann wrote: >> >> > On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: >> > > Defining these macros way down in arch/sh/.../irq.c doesn't

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 11:43:00 Thomas Gleixner wrote: > On Thu, 30 Oct 2014, Arnd Bergmann wrote: > > > On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: > > > Defining these macros way down in arch/sh/.../irq.c doesn't cause > > > kernel/irq/generic-chip.c to use them. As far as

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Thomas Gleixner
On Thu, 30 Oct 2014, Arnd Bergmann wrote: > On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: > > Defining these macros way down in arch/sh/.../irq.c doesn't cause > > kernel/irq/generic-chip.c to use them. As far as I can tell this code > > has no effect. > > > > Signed-off-by: Kevin

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Arnd Bergmann
On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: > Defining these macros way down in arch/sh/.../irq.c doesn't cause > kernel/irq/generic-chip.c to use them. As far as I can tell this code > has no effect. > > Signed-off-by: Kevin Cernekee Actually it overrides the 32-bit accessors

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Arnd Bergmann
On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: Defining these macros way down in arch/sh/.../irq.c doesn't cause kernel/irq/generic-chip.c to use them. As far as I can tell this code has no effect. Signed-off-by: Kevin Cernekee cerne...@gmail.com Actually it overrides the

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Thomas Gleixner
On Thu, 30 Oct 2014, Arnd Bergmann wrote: On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: Defining these macros way down in arch/sh/.../irq.c doesn't cause kernel/irq/generic-chip.c to use them. As far as I can tell this code has no effect. Signed-off-by: Kevin Cernekee

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 11:43:00 Thomas Gleixner wrote: On Thu, 30 Oct 2014, Arnd Bergmann wrote: On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: Defining these macros way down in arch/sh/.../irq.c doesn't cause kernel/irq/generic-chip.c to use them. As far as I can

Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-30 Thread Kevin Cernekee
On Thu, Oct 30, 2014 at 3:48 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 30 October 2014 11:43:00 Thomas Gleixner wrote: On Thu, 30 Oct 2014, Arnd Bergmann wrote: On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: Defining these macros way down in arch/sh/.../irq.c doesn't

[PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-29 Thread Kevin Cernekee
Defining these macros way down in arch/sh/.../irq.c doesn't cause kernel/irq/generic-chip.c to use them. As far as I can tell this code has no effect. Signed-off-by: Kevin Cernekee --- arch/sh/boards/mach-se/7343/irq.c | 3 --- arch/sh/boards/mach-se/7722/irq.c | 3 --- 2 files changed, 6

[PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

2014-10-29 Thread Kevin Cernekee
Defining these macros way down in arch/sh/.../irq.c doesn't cause kernel/irq/generic-chip.c to use them. As far as I can tell this code has no effect. Signed-off-by: Kevin Cernekee cerne...@gmail.com --- arch/sh/boards/mach-se/7343/irq.c | 3 --- arch/sh/boards/mach-se/7722/irq.c | 3 --- 2