Re: [PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-08 Thread Adrian Hunter
On 08/09/15 09:53, Jiri Olsa wrote: > On Mon, Sep 07, 2015 at 05:27:45PM +0300, Adrian Hunter wrote: >> The validation checks that the values that were just assigned, got >> assigned i.e. the error can't ever happen. Subsequent patches will >> call this code in places where errors are not being

Re: [PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-08 Thread Jiri Olsa
On Mon, Sep 07, 2015 at 05:27:45PM +0300, Adrian Hunter wrote: > The validation checks that the values that were just assigned, got > assigned i.e. the error can't ever happen. Subsequent patches will > call this code in places where errors are not being returned. > Changing those code paths to

Re: [PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-08 Thread Adrian Hunter
On 08/09/15 09:53, Jiri Olsa wrote: > On Mon, Sep 07, 2015 at 05:27:45PM +0300, Adrian Hunter wrote: >> The validation checks that the values that were just assigned, got >> assigned i.e. the error can't ever happen. Subsequent patches will >> call this code in places where errors are not being

Re: [PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-08 Thread Jiri Olsa
On Mon, Sep 07, 2015 at 05:27:45PM +0300, Adrian Hunter wrote: > The validation checks that the values that were just assigned, got > assigned i.e. the error can't ever happen. Subsequent patches will > call this code in places where errors are not being returned. > Changing those code paths to

[PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-07 Thread Adrian Hunter
The validation checks that the values that were just assigned, got assigned i.e. the error can't ever happen. Subsequent patches will call this code in places where errors are not being returned. Changing those code paths to return this non-existent error is counter-productive, so just remove it.

[PATCH V2 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps

2015-09-07 Thread Adrian Hunter
The validation checks that the values that were just assigned, got assigned i.e. the error can't ever happen. Subsequent patches will call this code in places where errors are not being returned. Changing those code paths to return this non-existent error is counter-productive, so just remove it.